Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event (and maybe other objects) missing 'updated_at' attribute. #407

Closed
tvongaza opened this issue Mar 10, 2023 · 0 comments · Fixed by #409
Closed

Event (and maybe other objects) missing 'updated_at' attribute. #407

tvongaza opened this issue Mar 10, 2023 · 0 comments · Fixed by #409
Assignees
Labels

Comments

@tvongaza
Copy link
Contributor

Describe the bug
The web API returns an updated_at field, however it is not included in the ruby library as a defined attribute.

To Reproduce
Some steps involved to reproduce the bug and any code samples you can share.

- Call the events api via curl and see the event having an updated_at field.
- Call the same event via the ruby sdk and see the ruby object does not have an updated_at field.

Expected behavior
The ruby events object should have the same fields, such as updated_at as the web api.

SDK Version:
Latest as of March 9, 2023.

Additional context
I monkey patched the event class as follows, which gets me the updated_at field as expected.

Nylas::Event.class_eval do
  attribute :updated_at, :integer, read_only: true
end
@tvongaza tvongaza added the bug label Mar 10, 2023
@kraju3 kraju3 self-assigned this Mar 13, 2023
mrashed-dev pushed a commit that referenced this issue Apr 4, 2023
The API returns updated_at for events, but it is not included in the ruby client event model. This PR adds the updated_at attribute and related spec. This was referenced in #407 which was closed by #409, but it didn't actually add the updated_at attribute.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants