Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skypeForConsumer as conferencing provider. #255

Conversation

SubashPradhan
Copy link
Contributor

  • Free Outlook accounts supports creating skype as conferencing while creating events.
  • Currently this is not listed as supported conferencing provider in JAVA sdk.
  • When user fetches event and an event has skype as conferencing, the request fails due to unsupported conferencing.
  • Add skypeForConsumer as supported conferencing provider.
  • Reproduced the error locally and tested the fix locally.

License

I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.82%. Comparing base (2dd721f) to head (98c7c6f).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #255   +/-   ##
=========================================
  Coverage     79.82%   79.82%           
  Complexity      287      287           
=========================================
  Files            31       31           
  Lines           897      897           
  Branches         88       88           
=========================================
  Hits            716      716           
  Misses          130      130           
  Partials         51       51           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SubashPradhan SubashPradhan merged commit 3e97fab into main Nov 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants