Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workaround for numbers that pass urns.ParseNumber but fail phone URN valdiation #1284

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

rowanseymour
Copy link
Member

No description provided.

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.91%. Comparing base (13265f7) to head (08275fa).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1284   +/-   ##
=======================================
  Coverage   81.90%   81.91%           
=======================================
  Files         276      276           
  Lines       17456    17459    +3     
=======================================
+ Hits        14298    14301    +3     
  Misses       2586     2586           
  Partials      572      572           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rowanseymour rowanseymour merged commit 152f305 into main Aug 21, 2024
7 checks passed
@rowanseymour rowanseymour deleted the parse_phone_fix branch August 21, 2024 14:54
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants