Support sending for WhatsApp URNs #1267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1267 +/- ##
==========================================
- Coverage 81.89% 81.88% -0.01%
==========================================
Files 276 276
Lines 17439 17443 +4
==========================================
+ Hits 14282 14284 +2
- Misses 2587 2588 +1
- Partials 570 571 +1 ☔ View full report in Codecov by Sentry. |
services/airtime/dtone/service.go
Outdated
| @@ -34,8 +35,10 @@ func (s *service) Transfer(sender urns.URN, recipient urns.URN, amounts map[stri | |||
| DesiredAmount: decimal.Zero, | |||
| ActualAmount: decimal.Zero, | |||
| } | |||
| // make sure we have the phone number with the + | |||
| recipientPhoneNumber := "+" + strings.TrimPrefix(recipient.Path(), "+") | |||
There was a problem hiding this comment.
go philosophy is not to be so clever.. so...
recipientPhoneNumber := recipient.Path()
if !strings.HasPrefix(recipientPhoneNumber, "+") {
recipientPhoneNumber = "+" + recipientPhoneNumber
}
rowanseymour
approved these changes
Jun 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.