Add transfer UUID field to airtime transfer #1266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1266 +/- ##
=======================================
Coverage 81.88% 81.89%
=======================================
Files 276 276
Lines 17443 17445 +2
=======================================
+ Hits 14284 14286 +2
Misses 2588 2588
Partials 571 571 ☔ View full report in Codecov by Sentry. |
norkans7
force-pushed
the
airtime-uuid
branch
2 times, most recently
from
463f418
to
0222807
Compare
| @@ -194,6 +194,7 @@ | |||
| "events": [ | |||
| { | |||
| "type": "airtime_transferred", | |||
| "uuid": "9688d21d-95aa-4bed-afc7-f31b35731a3d", | |||
There was a problem hiding this comment.
This should be transfer_uuid in case events themselves get uuids one day
norkans7
changed the title
flows/services.go
Outdated
| @@ -154,7 +157,7 @@ const ( | |||
|
|
|||
| // AirtimeTransfer is the result of an attempted airtime transfer | |||
| type AirtimeTransfer struct { | |||
| UUID uuids.UUID | |||
| TransferUUID AirtimeTransferUUID | |||
rowanseymour
approved these changes
Jun 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.