Merge pull request #1287 from nyaruka/contactql_inspect_fix

Fix inspection of contact queries using `group = ""` or `group != ""`
nyaruka · Sep 30, 2024 · 27e1fc0 · 27e1fc0
2 parents a005ed7 + df03be1
commit 27e1fc0
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/contactql/inspect.go b/contactql/inspect.go
@@ -36,7 +36,7 @@ func Inspect(query *ContactQuery) *Inspection {
 		case PropertyTypeAttribute:
 			attributes[c.propKey] = true
 
-			if c.propKey == AttributeGroup {
+			if c.propKey == AttributeGroup && c.value != "" {
 				if query.resolver != nil {
 					group := query.resolver.ResolveGroup(c.value)
 					addRef(assets.NewGroupReference(group.UUID(), group.Name()))

diff --git a/contactql/inspect_test.go b/contactql/inspect_test.go
@@ -102,6 +102,17 @@ func TestInspect(t *testing.T) {
 				AllowAsGroup: false,
 			},
 		},
+		{
+			query:    "group = \"\"", // group presence parsed with resolver
+			resolver: resolver,
+			inspection: &contactql.Inspection{
+				Attributes:   []string{"group"},
+				Schemes:      []string{},
+				Fields:       []*assets.FieldReference{},
+				Groups:       []*assets.GroupReference{},
+				AllowAsGroup: false,
+			},
+		},
 	}
 
 	for _, tc := range tests {