Fix FBA timestamps that sometimes are in seconds instead of milliseconds #666
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norkans7
force-pushed
the
fix-FBA-referral-dates
branch
from
2fe97c3 to
7ab4abb
Compare
norkans7
commented
Dec 4, 2023
| @@ -411,7 +411,7 @@ func (h *handler) processFacebookInstagramPayload(ctx context.Context, channel c | |||
|
|
|||
| var date time.Time | |||
|
|
|||
| if msg.Timestamp >= 10_000_000_000 { | |||
| if msg.Timestamp >= 100_000_000_000 { | |||
There was a problem hiding this comment.
@rowanseymour I found the right number to use is 100_000_000_000 that we cannot consider as milliseconds
after experimenting with https://www.epochconverter.com/
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #666 +/- ##
=======================================
Coverage 74.24% 74.24%
=======================================
Files 97 97
Lines 13127 13127
=======================================
Hits 9746 9746
Misses 2692 2692
Partials 689 689 ☔ View full report in Codecov by Sentry. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.