Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent all courier HTTP requests from accessing local networks #661

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

rowanseymour
Copy link
Member

Which required a bit of restructuring so that the backend which has access to the config, owns the HTTP clients used by handlers

@rowanseymour rowanseymour requested a review from norkans7 October 30, 2023 19:14
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #661 (eb08b7c) into main (8f8ef1b) will decrease coverage by 0.06%.
The diff coverage is 84.65%.

@@            Coverage Diff             @@
##             main     #661      +/-   ##
==========================================
- Coverage   74.31%   74.25%   -0.06%     
==========================================
  Files          99       97       -2     
  Lines       13129    13134       +5     
==========================================
- Hits         9757     9753       -4     
- Misses       2684     2692       +8     
- Partials      688      689       +1     
Files Coverage Δ
attachments.go 60.22% <100.00%> (ø)
backend.go 25.00% <ø> (ø)
handlers/africastalking/handler.go 90.42% <100.00%> (ø)
handlers/arabiacell/handler.go 75.80% <100.00%> (ø)
handlers/bandwidth/handler.go 70.77% <100.00%> (ø)
handlers/bongolive/handler.go 82.82% <100.00%> (ø)
handlers/burstsms/handler.go 84.48% <100.00%> (ø)
handlers/clickatell/handler.go 91.66% <100.00%> (ø)
handlers/clickmobile/handler.go 80.21% <100.00%> (ø)
handlers/clicksend/handler.go 77.96% <100.00%> (ø)
... and 53 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rowanseymour rowanseymour merged commit 5aea0f7 into main Oct 31, 2023
6 of 7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2023
@rowanseymour rowanseymour deleted the http_access branch October 31, 2023 18:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants