Finish switching to use slog for logging #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #660 +/- ##
==========================================
+ Coverage 74.04% 74.31% +0.27%
==========================================
Files 100 99 -1
Lines 13177 13129 -48
==========================================
Hits 9757 9757
+ Misses 2732 2684 -48
Partials 688 688 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
norkans7
force-pushed
the
slog-last
branch
2 times, most recently
from
08c0de8 to
1735228
Compare
norkans7
commented
Oct 13, 2023
| defer sentry.Flush(2 * time.Second) | ||
|
|
||
| logger = slog.New( | ||
| slogmulti.Fanout( |
There was a problem hiding this comment.
We need to use multi handlers here so that we can log the error both to sentry and the text logs on the servers
cmd/courier/main.go
Outdated
| @@ -87,51 +89,61 @@ func main() { | |||
| } | |||
|
|
|||
| // configure our logger | |||
| logrus.SetOutput(os.Stdout) | |||
| level, err := logrus.ParseLevel(config.LogLevel) | |||
| loggerLevel := new(slog.LevelVar) | |||
There was a problem hiding this comment.
do we need this? or can we just parse the Level value and then create the handler?
There was a problem hiding this comment.
using the levelVar is the only approach to support later changing the log level, but we change to use the parsed level and create a new handler.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes logrus use and add sentry handler for slog