fix: create result String/Buffer in native code #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronag
force-pushed
the
node-buffer
branch
7 times, most recently
from
ec3dfd8
to
238f0ee
Compare
legendecas
reviewed
Aug 27, 2024
| // overhead of registering lots of finalizers which is super slow. | ||
| // https://github.com/nodejs/node/issues/53804 | ||
| auto data = std::make_unique<std::vector<uint8_t>>(std::move(state.data)); | ||
| NAPI_STATUS_RETURN(napi_create_external_arraybuffer( |
There was a problem hiding this comment.
Just a note that in Node.js implementation, napi_create_external_arraybuffer is an alias for napi_create_external_buffer: https://github.com/nodejs/node/blob/main/src/js_native_api_v8.cc#L3027-L3041
ronag
force-pushed
the
master
branch
5 times, most recently
from
0be288b
to
9cf1ece
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: nodejs/node#54505