Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unreal Engine 5 compatibility update #248

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tonetechnician
Copy link
Contributor

@tonetechnician tonetechnician commented Mar 4, 2022

This PR contains the start of a migration to UE5 Preview. I struggled to find a way to get a macro that associates UE5 with Preview instead of Early Access. Closest I could find was the BRANCH_NAME macro. Maybe @nxrighthere you know of a better way? I guess once UE5 stable is out Early Access won't need to be supported.

There is also a deprecated warning for UObject->IsPendingKill function. I've left that out for now, I imagine if it is being deprecated we could just omit it in UE5.

Hope this helps!

@nxrighthere nxrighthere changed the title UE5 Preview compatibility UE5 Preview 1 compatibility update Mar 4, 2022
@nxrighthere
Copy link
Owner

Thanks. I'll check it.

@nxrighthere
Copy link
Owner

BoxSphereBounds became a generic type and should be changed accordingly in my codegen tool. I need to think about how to wrap it properly.

@tonetechnician
Copy link
Contributor Author

Yeah, that sounds right.

I believe they made it generic for the large world coordinates. I'm not sure if this will change back to a specific type with 5.0 stable. Reading the codebase, I saw there was mention that floats will become doubles in 5.0 to support large world coordinates.

@teddybee
Copy link

Will it work with preview2 as well?
In the preview 1 the float renamed to Real (probably double type), but in the preview 2, the float came back.

@tonetechnician
Copy link
Contributor Author

Yeah, I think there's been a few changes with these classes. Haven't yet tried to port to Preview 2, but on my task list for the week so can feedback here!

@nxrighthere
Copy link
Owner

nxrighthere commented Apr 5, 2022

Changing the Bounds structure will break compatibility with UE4, and this structure is based on double data types by default in UE5. Also, System.Numerics.Vectors doesn't support double-precision in .NET. 🤔

@nxrighthere
Copy link
Owner

There are a bunch of other methods that require refactoring for double precision. It seems that I have to make a separate branch for UE5 and maintain it along with master or drop support of UE4 entirely. 🙄

@nxrighthere nxrighthere changed the title UE5 Preview 1 compatibility update UE5 compatibility update Apr 5, 2022
@yajiedesign
Copy link

There are a bunch of other methods that require refactoring for double precision. It seems that I have to make a separate branch for UE5 and maintain it along with master or drop support of UE4 entirely. 🙄

Consider using "#if" solutions instead of maintaining different branches.

@eabemitchell
Copy link

Cool stuff... Any idea on a timeframe for when a UE5 compatible version will be ready for download? Or is there a test branch I can download now?

@dacanizares
Copy link

Nice! Any news regarding UE5 support?

@nxrighthere
Copy link
Owner

nxrighthere commented May 30, 2022

Consider using "#if" solutions instead of maintaining different branches.

That's probably an acceptable way to solve it, but I have no clue what to do with the double-precision math since it's not supported yet in System.Numerics.Vectors.

@nxrighthere nxrighthere changed the title UE5 compatibility update Unreal Engine 5 compatibility update May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants