Skip to content

Commit

Permalink
feat: add CFBundleIconFile
Browse files Browse the repository at this point in the history
  • Loading branch information
Ayushman Chhabra committed Jun 30, 2023
1 parent 491daa3 commit abe985b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/bld/osxCfg.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import { log } from "../log.js";
* @property {string} CFBundleVersion The version of the build that identifies an iteration of the bundle.
* @property {string} CFBundleShortVersionString The release or version number of the bundle.
* @property {string} NSHumanReadableCopyright A human-readable copyright notice for the bundle.
* @property {string} CFBundleIconFile The file containing the bundle's icon.
*/

/**
Expand Down Expand Up @@ -49,6 +50,7 @@ const setOsxConfig = async (app, outDir) => {
infoPlistJson.CFBundleVersion = app.CFBundleVersion;
infoPlistJson.CFBundleShortVersionString = app.CFBundleShortVersionString;
infoPlistJson.NSHumanReadableCopyright = app.NSHumanReadableCopyright;
infoPlistJson.CFBundleIconFile = app.CFBundleIconFile;

await fs.writeFile(infoPlistPath, plist.build(infoPlistJson));
} catch (error) {
Expand Down
1 change: 1 addition & 0 deletions src/util/parse.js
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ export const parse = async (options, pkg) => {
options.app.CFBundleShortVersionString ?? pkg.version;
options.app.NSHumanReadableCopyright =
options.app.NSHumanReadableCopyright ?? undefined;
options.app.CFBundleIconFile = options.app.CFBundleIconFile ?? "app.icns";
}

return { ...options };
Expand Down

0 comments on commit abe985b

Please sign in to comment.