Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[readme]: removing cdnvm command in readme for bashrc file #3231

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hasham7861
Copy link

There is an uncessary cdnvm "$PWD" || exit taking place and not all the systems that have bash come with $PWD variable and it was uncessarly causing my terminal to shut down, so I thought I remove it as it is uncessary

There is an uncessary `cdnvm "$PWD" || exit` taking place and not all the systems that have bash come with it, so its uncessary
@hasham7861 hasham7861 changed the title [Tag]: removing cdnvm command in readme for bashrc file [readme]: removing cdnvm command in readme for bashrc file Nov 17, 2023
@@ -626,7 +626,7 @@ cdnvm() {
}

alias cd='cdnvm'
cdnvm "$PWD" || exit
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$PWD is in posix, afaik; which systems don't come with it?

if the command isn't here, then a new shell won't have the logic applied, so it does have to remain.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for some reason it doesn't come by default on pop os, and kubuntu

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps those shells aren’t POSIX-compliant, then?

@ljharb ljharb marked this pull request as draft December 5, 2023 00:40
@ljharb ljharb force-pushed the master branch 2 times, most recently from c6cfc3a to c20db2a Compare June 10, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants