refactor: make executable check async #189
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
executable is sync version when one of formatter is not executable it will cause nvim block, make executable check async and move to FileType callback we don't need check all when config. just lazied check when need.
glepnir
force-pushed
the
async_executable
branch
from
35e88e9 to
8d0c023
Compare
|
lgtm? |
|
But the tests failed. |
|
I have a simple async/await lib. i guess we can use it to refactor guard ? ref https://github.com/glepnir/nvim/blob/main/plugin/async.lua |
I think just abstracting async patterns in guard is good enough, in a brief look, I think the library is not 100% guard specific :think: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
executable is sync version when one of formatter is not executable it will cause nvim block, make executable check async and move to FileType callback we don't need check all when config. just lazied check when need.