Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: switch nvim-cmp for blink.cmp #1426

Merged
merged 1 commit into from
Apr 9, 2025
Merged

Conversation

Saghen
Copy link
Contributor

@Saghen Saghen commented Mar 28, 2025

Opening as draft since I have yet to verify everything works as expected

Closes #1331

@cmdrrobin
Copy link
Contributor

cmdrrobin commented Mar 29, 2025

Tested and works fine. Although before nvim-cmp, it shows the documentations. Maybe we need to enable for blink.cmp as well.

opts = {
  completion = {
    -- Show documentation when available, with a small delay.
    -- If you're noticing high CPU usage or stuttering when opening the
    -- documentation, you may try setting
    -- `completion.documentation.treesitter_highlighting = false`.
    documentation = {
      auto_show = true,
      auto_show_delay_ms = 200,
    },
  },
}

UPDATE: don't know if it is my system, but couldn't trigger show/hide documents with default keymaps. (<C-Space>)

@raRaRa
Copy link

raRaRa commented Apr 6, 2025

What's the status on this? :)

@oriori1703
Copy link

fwiw, I have been using a version of this PR for over a week, and experienced no issues :D

@Saghen Saghen marked this pull request as ready for review April 6, 2025 20:06
@Saghen
Copy link
Contributor Author

Saghen commented Apr 6, 2025

Although before nvim-cmp, it shows the documentations. Maybe we need to enable for blink.cmp as well.

I've left this off by default but included a section about turning it on. This matches the behavior of built in completions and other major editors (i.e. vscode). I personally prefer the <C-Space> binding to show it as needed.

@feoh
Copy link
Collaborator

feoh commented Apr 9, 2025

This looks brilliant.

Not sure how to evaluate this versus the 'default completion' PR.

I know I personally would rather see new users have this experience but I haven't honestly tried the default yet so I'll go test and and report back, and see if we can't get this resolved with a modicum of screaming :)

Thank you!

@feoh
Copy link
Collaborator

feoh commented Apr 9, 2025

This is so very slightly slower than the 'native' completions as shown in the PR from @cmdrrobin .

However I personally favor the vastly increased flexibility available with different providers and the like.

Thus far I've seen way more strenuous opinions around a desire for the native completions support so I'm feeling rather like King Solomon at the moment :)

@Saghen
Copy link
Contributor Author

Saghen commented Apr 9, 2025

This is so very slightly slower than the 'native' completions

What the hell, sounds like I have some work for the weekend :) Which LSP?

@feoh
Copy link
Collaborator

feoh commented Apr 9, 2025

basedpyright. This is just my perception and I didn't do any formal benchmarking.

I'm not sure HOW I'd benchmark the two actually. I should look into that :)

@cmdrrobin
Copy link
Contributor

@feoh to be honest, I don't think it is worth the benchmark the two actually. ;-)

@feoh
Copy link
Collaborator

feoh commented Apr 9, 2025

You know what? I've seen several votes in favor of this PR and we don't have anyone who can support the 'native' version, so with thanks to @cmdrrobin and @Saghen for their hard work and participation I'm merging this.

Great work all!

@feoh feoh merged commit d350db2 into nvim-lua:master Apr 9, 2025
1 check passed
@Saghen Saghen deleted the blink-cmp branch April 9, 2025 22:33
dribic pushed a commit to dribic/nvim-files that referenced this pull request Apr 10, 2025
dimitrov-anasoft pushed a commit to dimitrov-anasoft/kickstart.nvim that referenced this pull request Apr 10, 2025
faizfrhn added a commit to faizfrhn/kickstart.nvim that referenced this pull request Apr 11, 2025
* feat: switch nvim-cmp for blink.cmp (nvim-lua#1426)
vencronys pushed a commit to vencronys/kickstart.nvim that referenced this pull request Apr 12, 2025
dazemc pushed a commit to dazemc/kickstart.nvim that referenced this pull request Apr 12, 2025
DerFrZocker pushed a commit to DerFrZocker/.dotfiles-nvim that referenced this pull request Apr 12, 2025
musllim pushed a commit to musllim/kickstart.nvim that referenced this pull request Apr 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use blink.cmp over nvim-cmp?
5 participants