Skip to content

Commit

Permalink
Fix conflict
Browse files Browse the repository at this point in the history
  • Loading branch information
nvdaes committed Dec 22, 2020
2 parents d3c8742 + 6dc65e2 commit b25f6b4
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 14 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/upload-on-tag.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
import re
with open("buildVars.py", 'r+', encoding='utf-8') as f:
text = f.read()
text = re.sub("\"addon_version\" : ", "\"addon_version\" : \"${{ github.ref }}\"", text)
text = re.sub("\"addon_version\" : ", "\"addon_version\" : \"${{ github.ref }}.split("/")[-1]\"", text)
f.seek(0)
f.write(text)
f.truncate()
Expand Down
11 changes: 7 additions & 4 deletions addon/globalPlugins/readFeeds/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -618,10 +618,13 @@ def getArticleTimestamp(self, article):
return 0

def refresh(self):
userAgent = "UniversalFeedParser/3.3 +http://feedparser.org/"
headers = {'User-Agent': userAgent}
req = urllib.request.Request(self._url, None, headers)
response = urllib.request.urlopen(req)
try:
response = urllib.request.urlopen(self._url)
except Exception:
userAgent = "UniversalFeedParser/3.3 +http://feedparser.org/"
headers = {'User-Agent': userAgent}
req = urllib.request.Request(self._url, None, headers)
response = urllib.request.urlopen(req)
try:
self._document = ElementTree.parse(response)
except Exception as e:
Expand Down
10 changes: 1 addition & 9 deletions changelog.md
Original file line number Diff line number Diff line change
@@ -1,9 +1 @@
## Changes for 10.0 ##

* Added a button to open the selected feed as HTML in the default web browser.
* If a new feed cannot be created, this will be notified in an error dialog.
* Improved order and presentation of some articles.
* More feeds may be supported.
* When the feeds dialog is opened, the list of feeds will be focused instead of the search edit box.
* You can choose if the search edit box is placed after the list of feeds, useful to focus the list event when switching from another window without closing the Feeds dialog.
* Added a button to copy the feed address to clipboard from the feeds dialog.
* Read feeds providing a user agent just as a fallback.
1 change: 1 addition & 0 deletions scons.bat
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
scons

0 comments on commit b25f6b4

Please sign in to comment.