Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated espeak-ng to 1.52-Development-latest #17206

Closed
wants to merge 2 commits into from

Conversation

dpy013
Copy link
Contributor

@dpy013 dpy013 commented Sep 23, 2024

Link to issue number:

#17056

Summary of the issue:

Updated espeak-ng to 1.52 (In Development) 21ac2203a0b22f3816e21932feff8ae9c12eb78a

Description of user facing changes

Not yet.

Description of development approach

updated include/espeak-ng to latest commit

Testing strategy:

You need to look at the compiled build and test the latest espeak-ng commit.

Known issues with pull request:

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

1.52 (In Development) 21ac2203a0b22f3816e21932feff8ae9c12eb78a
@dpy013 dpy013 requested a review from a team as a code owner September 23, 2024 08:26
@dpy013 dpy013 marked this pull request as draft September 23, 2024 08:27
@seanbudd
Copy link
Member

just confirming, did you follow all the steps in espeak.md?

@seanbudd seanbudd added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Sep 24, 2024
@dpy013
Copy link
Contributor Author

dpy013 commented Sep 24, 2024

just confirming, did you follow all the steps in espeak.md?

I'm a little confused about DPACKAGE_VERSION.
How should I update him? For example, the following example:
'/DPACKAGE_VERSION=\"1.52-dev 961454ff\"', # See 'include/espeak/src/windows/config.h'

@seanbudd
Copy link
Member

Update the commit hash in DPACKAGE_VERSION with the latest commit. I don't think the version has bumped from 1.52 yet

@SaschaCowley
Copy link
Member

Please also add a changes entry, and confirm whether you have performed the testing steps as described in our documentation on updating eSpeak-ng.

@SaschaCowley SaschaCowley linked an issue Sep 24, 2024 that may be closed by this pull request
@cary-rowen
Copy link
Contributor

ESpeak NG affects a wide range of users. Please follow the steps in espeak.md for complete testing.

@dpy013
Copy link
Contributor Author

dpy013 commented Sep 25, 2024

Currently pr is immature, need to look specifically at espeak repositories

@dpy013 dpy013 closed this Sep 25, 2024
@dpy013 dpy013 deleted the Update-espeak-ng branch September 25, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update eSpeak-NG for 2025.1
4 participants