Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RC to beta #17138

Merged
merged 2 commits into from
Sep 9, 2024
Merged

RC to beta #17138

merged 2 commits into from
Sep 9, 2024

Commits on Sep 9, 2024

  1. Empty commit for CI

    @seanbudd
    seanbudd committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    3e20720 View commit details
    Browse the repository at this point in the history

  2. Support compiling with VS 2022 V17.11 (#17028) 

    Fixes #17026

Summary of the issue:
Trying to compile NVDA with Visual Studio 2022 V17.11 produces the following error:

build\x86\local\beeps.cpp(19): error C2039: 'min': is not a member of 'std'
std::min and std::max are defined in <algorithm> which we never include in beeps.cpp. I assume that <cmath> used to include <algorithm> and now it does not.

Description of user facing changes
None.

Description of development approach
Include <algorithm> in beeps.cpp.
    @michaelDCurran @seanbudd
    michaelDCurran authored and seanbudd committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    7bcef1b View commit details
    Browse the repository at this point in the history