Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Beta to master #17085

Merged
merged 3 commits into from
Aug 30, 2024
Merged

Beta to master #17085

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d2852e6
Revert change introduced in c333bef
SaschaCowley Aug 30, 2024
d312a7b
Added change log entry
SaschaCowley Aug 30, 2024
4d1a43c
Merge pull request #17084 from nvaccess/try-i17027
seanbudd Aug 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions source/NVDAObjects/JAB/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,11 +184,8 @@ def _getLineOffsets(self, offset: int) -> tuple[int, int]:
if end == -1 and offset > 0:
# #1892: JAB returns -1 for the end insertion position
# instead of returning the offsets for the last line.
# Try one character back, unless we're on a new line.
if self.obj.jabContext.getAccessibleTextRange(offset - 1, offset - 1) != "\n":
(start, end) = self.obj.jabContext.getAccessibleTextLineBounds(offset - 1)
else:
(start, end) = (offset, offset)
# Try one character back.
(start, end) = self.obj.jabContext.getAccessibleTextLineBounds(offset - 1)
# Java gives end as the last character, not one past the last character
end = end + 1
return (start, end)
Expand Down
1 change: 1 addition & 0 deletions user_docs/en/changes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ There have also been a number of fixes, including to mouse tracking in Firefox,
* It is now possible to interact with Data validation dropdown lists in Microsoft Excel 365. (#15138)
* NVDA is no longer as sluggish when arrowing up and down through large files in VS Code. (#17039)
* NVDA no longer becomes unresponsive after holding down an arrow key for a long time while in browse mode, particularly in Microsoft Word and Microsoft Outlook. (#16812)
* NVDA no longer reads the last line when the cursor is on the second-last line of a multiline edit control in Java applications. (#17027)

### Changes for Developers

Expand Down