-
-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Fix reading the last empty line of a text in apps using Java Access Bridge" #17083
Conversation
WalkthroughThe changes involve modifications to the NVDA screen reader's functionality, specifically improving how line offsets are calculated in the Java Access Bridge module. The updates address an issue where NVDA incorrectly read the last line of text when the cursor was positioned on the second-last line in Java applications, enhancing the accuracy of the screen reader's output. Changes
Assessment against linked issues
Recent review detailsConfiguration used: .coderabbit.yml Files selected for processing (2)
Additional context usedPath-based instructions (2)
Additional comments not posted (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Reverts PR
Reverts #16568
Issues fixed
Fixes #17027
Issues reopened
Reopens #9376
Reason for revert
The changes introduced a bug whereby if the final line was not blank, it would be read in place of the second-last line.
Can this PR be reimplemented? If so, what is required for the next attempt
The changes introduced are desirable if the case of erroneously reporting the last line instead of the second-last line can be resolved.
Summary by CodeRabbit