Support compiling with VS 2022 V17.11

[michaelDCurran]

Link to issue number:

Fixes #17026

Summary of the issue:

Trying to compile NVDA with Visual Studio 2022 V17.11 produces the following error:

build\x86\local\beeps.cpp(19): error C2039: 'min': is not a member of 'std'

std::min and std::max are defined in <algorithm> which we never include in beeps.cpp. I assume that <cmath> used to include <algorithm> and now it does not.

Description of user facing changes

None.

Description of development approach

Include <algorithm> in beeps.cpp.

Testing strategy:

Successfully compiled NvDA with VS 2022 V17.11.

Known issues with pull request:

None known.

Code Review Checklist:

• Documentation:
  • Change log entry
  • User Documentation
  • Developer / Technical Documentation
  • Context sensitive help for GUI changes
• Testing:
  • Unit tests
  • System (end to end) tests
  • Manual testing
• UX of all users considered:
  • Speech
  • Braille
  • Low Vision
  • Different web browsers
  • Localization in other languages / culture than English
• API is compatible with existing add-ons.
• Security precautions taken.

Summary by CodeRabbit

• New Features
  • Introduced enhanced algorithmic capabilities in the application, improving functionality related to processing.

[coderabbitai]

Walkthrough

The recent changes involve the addition of the <algorithm> header in the beeps.cpp file of the NVDA project. This modification aims to improve the availability of algorithmic functions, potentially resolving compilation errors related to standard functions not being recognized. However, no direct changes to the existing logic or functionality are made in this update.

Changes

Files	Change Summary
nvdaHelper/local/beeps.cpp	Added #include <algorithm> to utilize standard algorithms.

Assessment against linked issues

Objective	Addressed	Explanation
Identify Build Failure ( #17026 )	✅
Error Details ( #17026 )	✅
Expected Outcome ( #17026 )	❓	The addition of the header may resolve errors, but functionality isn't confirmed.
Persistence of Issue ( #17026 )	❌	The core issue of compilation failure is not directly addressed.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[SaschaCowley]

I don't see how this would break anything, but I think it's still safest to keep it in alpha for a while just in case

[AppVeyorBot]

• PASS: Translation comments check.
• PASS: License check.
• PASS: Unit tests.
• PASS: Lint check.
• FAIL: System tests (tags: installer NVDA). See test results for more information.
• Build (for testing PR): https://ci.appveyor.com/api/buildjobs/b9aey4730e5afx2v/artifacts/output/nvda_snapshot_pr17028-33461,d097a60f.exe
• CI timing (mins):
  INIT 0.0,
  INSTALL_START 1.2,
  INSTALL_END 0.9,
  BUILD_START 0.0,
  BUILD_END 11.7,
  TESTSETUP_START 0.0,
  TESTSETUP_END 0.3,
  TEST_START 0.0,
  TEST_END 18.0,
  FINISH_END 0.1

See test results for failed build of commit d097a60fe7

[seanbudd]

I think it's best to merge as the AppVeyor image may update during our release cycle

[SaschaCowley]

That makes sense