Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installer to delete nvda_eoaProxy.exe #17023

Merged
merged 1 commit into from
Aug 19, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions source/installer.py
Original file line number Diff line number Diff line change
Expand Up @@ -807,10 +807,10 @@ def install(shouldCreateDesktopShortcut: bool = True, shouldRunAtLogon: bool = T
# which executables exist after copying program files.
# Some exes are no longer used, but we remove them anyway from legacy copies.
# nvda_service.exe was removed in 2017.4 (#7625).
# TODO: nvda_eoaProxy.exe should be added to this list in 2024.1 (#15544).
# nvda_eoaProxy.exe existed to support Windows 7 Ease of Access, and was removed in 2024.1 (#15577).
_deleteFileGroupOrFail(
installDir,
_nvdaExes.union({"nvda_service.exe"}),
_nvdaExes.union({"nvda_service.exe", "nvda_eoaProxy.exe"}),
numTries=6,
retryWaitInterval=0.5,
)
Expand Down