Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give ui.browseableMessage the ability to show copy and close buttons after the message, and add buttons to some instances (2nd try) #17018

Merged
merged 15 commits into from
Aug 29, 2024
Merged

Give ui.browseableMessage the ability to show copy and close buttons after the message, and add buttons to some instances (2nd try) #17018

merged 15 commits into from
Aug 29, 2024

Commits on Aug 16, 2024

  1. Add Copy and Close buttons to ui.browseableMessage, and a few of its … 

    …instances.

* Report link destination, Speak selection command, & character formatting browseableMessages given close and copy buttons.
* Added a new browsable message component failure messaging function.
* Used a live region to alert users about the status of the copy operation.
* Added some further error handling, as proposed by the AI.
* Change onkeypress to onkeydown, in order to pick up modifier keys in message.html.
* Used Ctrl+Shift+C for the copy button accelerator key, because Alt+C makes a Windows error ding.
* Switch to innerText from innerHTML where possible.
* Remove invalid language attribute on body element in message.html per review.
* Solve for MSHTML bug in the use of aria-labelledby.
* Close the MSHTML Window if args wasn't provided for some reason.
    Luke Davis authored and Luke Davis committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    be5769f View commit details
    Browse the repository at this point in the history

  2. Make the _warningBrowseableMessage* functions self-contained with res… 

    …pect to wx.
    Luke Davis authored and Luke Davis committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    5b76026 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2024

  1. Pre-commit auto-fix

    @pre-commit-ci
    pre-commit-ci[bot] committed Aug 18, 2024
    Configuration menu
    Copy the full SHA
    5b9a898 View commit details
    Browse the repository at this point in the history

  2. Changes

    Luke Davis authored and Luke Davis committed Aug 18, 2024
    Configuration menu
    Copy the full SHA
    b4a462e View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. New handleKeyPress code in JS, as proposed by the AI.

    Luke Davis, Open Source Systems authored and Luke Davis, Open Source Systems committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    eacc8c1 View commit details
    Browse the repository at this point in the history

  2. AI proposed more modern copy code. AI isn't sure if it will work.

    Luke Davis, Open Source Systems authored and Luke Davis, Open Source Systems committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    f58e85f View commit details
    Browse the repository at this point in the history

  3. Revert "AI proposed more modern copy code. AI wasn't sure if it worke… 

    …d, and it doesn't.

This reverts commit f58e85f.
    Luke Davis, Open Source Systems authored and Luke Davis, Open Source Systems committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    c071400 View commit details
    Browse the repository at this point in the history

  4. AI suggested improvement to error logging detail.

    Luke Davis, Open Source Systems authored and Luke Davis, Open Source Systems committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    b50e031 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into fix14641again

    Luke Davis authored and Luke Davis committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    b41b6ea View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2024

  1. Merge branch 'master' into fix14641again

    Luke Davis authored and Luke Davis committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    06f731e View commit details
    Browse the repository at this point in the history

  2. Fix a bug where copy accelerator still worked, even if button wasn't … 

    …shown.
    Luke Davis authored and Luke Davis committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    2eab076 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. Merge branch 'master' into fix14641again

    Luke Davis authored and Luke Davis committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    e1ccda5 View commit details
    Browse the repository at this point in the history

  2. Changes update

    Luke Davis authored and Luke Davis committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    ce75b54 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2024

  1. Update source/ui.py

    @seanbudd
    seanbudd authored Aug 29, 2024
    Configuration menu
    Copy the full SHA
    28baf8c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix14641again

    @seanbudd
    seanbudd authored Aug 29, 2024
    Configuration menu
    Copy the full SHA
    4dc3c77 View commit details
    Browse the repository at this point in the history