Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add meta-hooks for pre-commit validation #17012

Merged
merged 5 commits into from
Aug 16, 2024
Merged

Add meta-hooks for pre-commit validation #17012

merged 5 commits into from
Aug 16, 2024

Conversation

seanbudd
Copy link
Member

@seanbudd seanbudd commented Aug 16, 2024

Link to issue number:

None

Summary of the issue:

  • pre-commit CI doesn't use a pinned version of python
  • the pre-commit CI file is not validated by pre-commit
  • pre-commit CI doesn't run our license check or unit tests. Further investigation was performed to see if this was possible. Unfortunately it is not.

Description of user facing changes

  • pin pre-commits python env version to 3.11
  • add validation for our pre-commit config with meta hooks
  • expand notes on why unit testing and license check is not possible with pre-commit CI, there's no way to consistently having a matching python venv to local devs, and no custom telemetry.

Description of development approach

Testing strategy:

Run pre-commit on all files

Known issues with pull request:

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@seanbudd seanbudd requested a review from a team as a code owner August 16, 2024 00:47
Copy link
Contributor

coderabbitai bot commented Aug 16, 2024

Walkthrough

The changes to the .pre-commit-config.yaml file enhance the configuration for continuous integration by refining the comments, updating the Python version, and streamlining the skip list. A new repository for managing the pre-commit CI configuration is added, alongside significant modifications to the licenseCheck hook, simplifying its execution and dependencies. Overall, these updates improve clarity, functionality, and maintainability.

Changes

File Change Summary
.pre-commit-config.yaml Updated default_language_version to python3.11; refined comments for ci section; adjusted skip list by removing licenseCheck; added pre-commit CI repository; modified licenseCheck hook to simplify file patterns, update entry command, and include additional dependencies.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

.pre-commit-config.yaml Outdated Show resolved Hide resolved
@seanbudd seanbudd marked this pull request as draft August 16, 2024 01:10
@seanbudd seanbudd changed the title Support license check in pre-commit CI Add meta-hooks for pre-commit validation Aug 16, 2024
@seanbudd seanbudd marked this pull request as ready for review August 16, 2024 01:13
.pre-commit-config.yaml Outdated Show resolved Hide resolved
Co-authored-by: Sascha Cowley <[email protected]>
@seanbudd seanbudd merged commit 3fd1f07 into master Aug 16, 2024
4 checks passed
@seanbudd seanbudd deleted the preCommitLiCheck branch August 16, 2024 06:31
@github-actions github-actions bot added this to the 2024.4 milestone Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants