Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address issues in userGuide and keyCommands found when researching markdown translation string extraction #16119

Merged
merged 3 commits into from
Feb 2, 2024

Commits on Feb 1, 2024

  1. Configuration menu
    Copy the full SHA
    dbf6ff3 View commit details
    Browse the repository at this point in the history
  2. keyCommandsDoc.py: Refactored _handleSetting to fix the following iss…

    …ues:
    
    * Previous headings for single settings were accidentally being included in the document before the start of a settings table. E.g. Browse Mode -> Maximum line length (which has no keyboard shortcut, was being included before Use Screen layout). This therefore also broke the Browse Mode table in to smaller tables.
    * Tables were not being correctly ended with a blank line as markdown requires, so sometimes subsequent headings were being shown as raw markdown as part of the previous table. e.g. The Synth settings ring heading was being shown as raw markdown within the Synthesizer Selection table.
    
    Also correct 0-based heading level counting: the first heading symbol in t2t is of length 1, but in markdown it is of length 2.
    this stops the "Introduction" heading from accidentally appearing at the top of the key commands doc.
    michaelDCurran committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    1992f9e View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2024

  1. add typing

    seanbudd authored Feb 2, 2024
    Configuration menu
    Copy the full SHA
    714ce8f View commit details
    Browse the repository at this point in the history