Refactor wxWidgets app creation from core.main #16081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanbudd
requested review from
michaelDCurran and
gerald-hartig
and removed request for
michaelDCurran
| @@ -9,6 +9,7 @@ | |||
|
|
|||
| from dataclasses import dataclass | |||
| from typing import ( | |||
| TYPE_CHECKING, | |||
There was a problem hiding this comment.
Love this. TIL about TYPE_CHECKING variable.
gerald-hartig
approved these changes
Jan 28, 2024
|
|
||
| import wx |
There was a problem hiding this comment.
Given that you're importing wx in 3 different places, including in the main execution flow, can we just put the single import up at the top of the core.py file? If there's no way to avoid loading it (which it looks like from def main()), we can simplify the imports and remove the TYPE_CHECKING logic.
There was a problem hiding this comment.
I believe we are intentionally avoiding the wx import until further down. Dependency importing is incredibly order specific in nvda.pyw and core.py
| @@ -527,6 +531,66 @@ def _doLoseFocus(): | |||
| log.exception("Lose focus error") | |||
|
|
|||
|
|
|||
| def _setUpWxApp() -> "wx.App": | |||
There was a problem hiding this comment.
I really like the refactor of this out of main(). Much better.
Nael-Sayegh
pushed a commit
to Nael-Sayegh/nvda
that referenced
this pull request
Feb 15, 2024
SaschaCowley
pushed a commit
to SaschaCowley/nvda
that referenced
this pull request
Feb 27, 2024
Adriani90
pushed a commit
to Adriani90/nvda
that referenced
this pull request
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup of 64e6413