Merge beta to master #16075
Merged
Merge beta to master #16075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ose (#16074) Fixes #16070 Summary of the issue: To log unhandled exceptions NVDA relies on a custom except hook installed when initializing logging. Until Python 3.8 custom except hooks were not called for exception which occurred outside of the main thread - they were simply written to stderr (see python/cpython#42148). This worked well for NVDA, since it replaces stderr with a custom object which logs everything written to stderr, so the exceptions ended up in our log, just in a different way. In Python 3.8 it become possible to install a custom hook which gets called for exceptions which are raised in non main threads, but as part of this change the way in which they are handled by default has changed - the traceback is written to stderr line by line, rather than as a single call to print as it used to be. For NVDA it means that each line of the traceback results in a separate log entry making logging extremely noisy. Description of user facing changes Exception from threads different than the main one are logged in the same way as they were in NVDA 2023.3. Description of development approach A custom except hook for exception raised in threads was introduced. It logs them as an exception with additional information explaining in which thread they were raised. Testing strategy: Performed STR from #16070 - ensured that logging looks similarly to the one from 2023.3 and that single exception results in a single log entry. Known issues with p
Summary of the issue: Everyone may not know what speech modes are, especially the new on-demand mode. Description of user facing changes In the User Guide, there is a paragraph describing the setting to change available speech mode in the cycling command. A link has been added to the paragraph describing the speech modes. While at it, I have also rephrased a script's documentation, which inappropriately mentions "peech modes" when referring to language switching possible values; this way, it's not confusing anymore when searching for "speech mode" in the UG
…and also clarify some information about MathPlayer. (#16062) Fixes #16036 Fixes #15352 Summary of the issue: When reading the section of the User guide about Math support, and then the MathPlayer page from Wiris, it is unclear as to whether MathPlayer is actually needed for NvDA unless you are using an older browser such as Internet Explorer 8. Also, Nthe User Guide does not recommend let alone mention, MathCAT, which is now the replacement for the older and unmaintained MathPlayer. Description of user facing changes Update the math section in the User guide to mention and recommend MathCAT, and clarify that MathPlayer is still relevant on newer browsers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.