-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace conda-mambabuild
with conda-build
#2192
Conversation
These are now equivalent in behavior. However support for `conda-mambabuild` is being dropped. So switch to `conda-build`.
Am unable to add labels here. So please add them on my behalf |
/ok to test |
/ok to test |
Thanks Will! 🙏 Looks like the builds pass, which is what this PR affects. There is a documentation failure and a test failure. Though those appear to be unrelated to the change at hand. |
@jakirkham yes :) After some investigation, it looks like cudf 24.02 has been updated, so I need to pin it to 24.02.00 I need to open some PRs and get them merged, then this PR can be rebased on branch-25.06 once this is done. |
Sounds good. Thanks Will! 🙏 Please let me know when you are ready for me to take next steps here 🙂 |
@jakirkham once #2194 is merged, you will need to rebase on |
Thanks Will! 🙏 Looks like your PR was merged. Have pulled in latest changes into this PR Could you please start CI? |
/ok to test |
/ok to test |
The default behavior of `conda-build` is to use packages from its local cache. Given this, we don't need this flag. It also causes `conda-build` to look in a different place than we typically use for the package cache on CI, which causes its own problems.
@@ -105,9 +105,6 @@ if hasArg upload; then | |||
fi | |||
fi | |||
|
|||
# Some default args | |||
CONDA_ARGS_ARRAY+=("--use-local") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As conda-build
always uses its local cache, the --use-local
flag is unneeded
Additionally it appears conda-build
has a bug that causes it to look inside its package cache before it is created, which causes the following CI error
UnavailableInvalidChannel: HTTP 404 UNAVAILABLE OR INVALID for channel conda-bld-output <file:///tmp/conda-bld-output>
The channel is not accessible or is invalid.
You will need to adjust your conda configuration to proceed.
Use `conda config --show channels` to view your configuration's current state,
and use `conda config --show-sources` to view config file locations.
As of conda 4.3, a valid channel must contain a `noarch/repodata.json` and
associated `noarch/repodata.json.bz2` file, even if `noarch/repodata.json` is
empty. Use `conda index /tmp/conda-bld-output`, or create `noarch/repodata.json`
and associated `noarch/repodata.json.bz2`.
Typically we use our own package cache location. So this isn't even the right place for it to check
Since we don't need this flag here (nor use it elsewhere), it is easy enough to drop, which fixes all of these issues
/ok to test |
/ok to test |
Discussed this offline with Will. We've decided this isn't worth pursuing further Decided this because we plan to move to |
Description
These are now equivalent in behavior. However support for
conda-mambabuild
is being dropped. So switch toconda-build
.xref: rapidsai/build-planning#149
By Submitting this PR I confirm: