Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace conda-mambabuild with conda-build #2192

Closed
wants to merge 4 commits into from

Conversation

jakirkham
Copy link

Description

These are now equivalent in behavior. However support for conda-mambabuild is being dropped. So switch to conda-build.

xref: rapidsai/build-planning#149

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

These are now equivalent in behavior. However support for
`conda-mambabuild` is being dropped. So switch to `conda-build`.
@jakirkham jakirkham requested a review from a team as a code owner February 28, 2025 20:36
Copy link

copy-pr-bot bot commented Feb 28, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@jakirkham
Copy link
Author

Am unable to add labels here. So please add them on my behalf

@jakirkham
Copy link
Author

/ok to test

@willkill07 willkill07 added non-breaking Non-breaking change improvement Improvement to existing functionality labels Mar 3, 2025
@willkill07
Copy link
Member

/ok to test

@jakirkham
Copy link
Author

Thanks Will! 🙏

Looks like the builds pass, which is what this PR affects.

There is a documentation failure and a test failure. Though those appear to be unrelated to the change at hand.

@willkill07
Copy link
Member

@jakirkham yes :) After some investigation, it looks like cudf 24.02 has been updated, so I need to pin it to 24.02.00

I need to open some PRs and get them merged, then this PR can be rebased on branch-25.06 once this is done.

@jakirkham
Copy link
Author

Sounds good. Thanks Will! 🙏

Please let me know when you are ready for me to take next steps here 🙂

@willkill07
Copy link
Member

@jakirkham once #2194 is merged, you will need to rebase on branch-25.06 then we can get this merged. Just awaiting an approval.

@jakirkham
Copy link
Author

Thanks Will! 🙏

Looks like your PR was merged. Have pulled in latest changes into this PR

Could you please start CI?

@willkill07
Copy link
Member

/ok to test

@willkill07 willkill07 added the conda-build Enables running the conda-build step on a PR label Mar 4, 2025
@willkill07
Copy link
Member

/ok to test

The default behavior of `conda-build` is to use packages from its local
cache. Given this, we don't need this flag. It also causes `conda-build`
to look in a different place than we typically use for the package cache
on CI, which causes its own problems.
@@ -105,9 +105,6 @@ if hasArg upload; then
fi
fi

# Some default args
CONDA_ARGS_ARRAY+=("--use-local")
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As conda-build always uses its local cache, the --use-local flag is unneeded

Additionally it appears conda-build has a bug that causes it to look inside its package cache before it is created, which causes the following CI error

UnavailableInvalidChannel: HTTP 404 UNAVAILABLE OR INVALID for channel conda-bld-output <file:///tmp/conda-bld-output>

The channel is not accessible or is invalid.

You will need to adjust your conda configuration to proceed.
Use `conda config --show channels` to view your configuration's current state,
and use `conda config --show-sources` to view config file locations.

As of conda 4.3, a valid channel must contain a `noarch/repodata.json` and
associated `noarch/repodata.json.bz2` file, even if `noarch/repodata.json` is
empty. Use `conda index /tmp/conda-bld-output`, or create `noarch/repodata.json`
and associated `noarch/repodata.json.bz2`.

Typically we use our own package cache location. So this isn't even the right place for it to check

Since we don't need this flag here (nor use it elsewhere), it is easy enough to drop, which fixes all of these issues

@willkill07
Copy link
Member

/ok to test

@willkill07
Copy link
Member

/ok to test

@jakirkham
Copy link
Author

jakirkham commented Mar 7, 2025

Discussed this offline with Will. We've decided this isn't worth pursuing further

Decided this because we plan to move to rattler-build ( #2191 ) and we are still seeing some issues with conda-build that we don't think are worth fixing

@jakirkham jakirkham closed this Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conda-build Enables running the conda-build step on a PR improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants