Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt Python 3.12 #2184

Open
wants to merge 80 commits into
base: branch-25.06
Choose a base branch
from

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Feb 19, 2025

Description

Closes #2181

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

mroeschke and others added 30 commits January 9, 2025 11:59
Cleanup DOCA env vars
Remove redundant calls to `apt update`, remove call to `apt upgrade`.
Fix download location for `doca-host.deb`
Consolidate installing of doca packagwes
@willkill07
Copy link
Member

/ok to test

@willkill07
Copy link
Member

/ok to test

Signed-off-by: Will Killian <[email protected]>
@willkill07
Copy link
Member

/ok to test

1 similar comment
@willkill07
Copy link
Member

/ok to test

Signed-off-by: Will Killian <[email protected]>
@willkill07
Copy link
Member

/ok to test

@willkill07
Copy link
Member

/ok to test

Signed-off-by: Will Killian <[email protected]>
@willkill07
Copy link
Member

/ok to test

@dagardner-nv
Copy link
Contributor Author

/ok to test

Signed-off-by: Will Killian <[email protected]>
@willkill07
Copy link
Member

/ok to test

@willkill07
Copy link
Member

/ok to test

@willkill07
Copy link
Member

/ok to test

Copy link
Member

@willkill07 willkill07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are additional comments to aid in the review of this PR.

@dagardner-nv
Copy link
Contributor Author

/ok to test

@efajardo-nv
Copy link
Contributor

Release container build doesn't work for me:

27.89 Adding in variants from internal_defaults
27.89 Adding in variants from /workspace/ci/conda/recipes/morpheus/conda_build_config.yaml
28.59 Error: bad character '=' in package version dependency 'librdkafka'
28.59 Perhaps you meant 'librdkafka =2.6.1'
------
Dockerfile:270
--------------------
 269 |
 270 | >>> RUN --mount=type=cache,id=workspace_cache,target=/workspace/.cache,sharing=locked \
 271 | >>>     --mount=type=cache,id=conda_pkgs,target=/opt/conda/pkgs,sharing=locked \
 272 | >>>     --mount=type=cache,id=pip_cache,target=/root/.cache/pip,sharing=locked \
 273 | >>>     # Install git-lfs before running the build to avoid errors during conda build
 274 | >>>     /opt/conda/bin/mamba install -y -n base -c conda-forge "git-lfs" &&\
 275 | >>>     source activate base &&\
 276 | >>>     git lfs install &&\
 277 | >>>     # Need to get around recent versions of git locking paths until they are deemed safe
 278 | >>>     git config --global --add safe.directory "*" &&\
 279 | >>>     # Change to the morpheus directory and build the conda package
 280 | >>>     cd ${MORPHEUS_ROOT_HOST} &&\
 281 | >>>     MORPHEUS_PYTHON_BUILD_STUBS=OFF CONDA_BLD_PATH=/opt/conda/conda-bld ./ci/conda/recipes/run_conda_build.sh morpheus
 282 |
--------------------
ERROR: failed to solve: process "/bin/bash -c /opt/conda/bin/mamba install -y -n base -c conda-forge \"git-lfs\" &&    source activate base &&    git lfs install &&    git config --global --add safe.directory \"*\" &&    cd ${MORPHEUS_ROOT_HOST} &&    MORPHEUS_PYTHON_BUILD_STUBS=OFF CONDA_BLD_PATH=/opt/conda/conda-bld ./ci/conda/recipes/run_conda_build.sh morpheus" did not complete successfully: exit code: 1

@willkill07
Copy link
Member

/ok to test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change conda-build Enables running the conda-build step on a PR dependencies Pull requests that update a dependency file feature request New feature or request
Projects
Status: Review - Ready for Review
Development

Successfully merging this pull request may close these issues.

[FEA]: Support python 3.12
4 participants