-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt Python 3.12 #2184
Open
dagardner-nv
wants to merge
80
commits into
nv-morpheus:branch-25.06
Choose a base branch
from
dagardner-nv:david-py-312-2181
base: branch-25.06
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Adopt Python 3.12 #2184
dagardner-nv
wants to merge
80
commits into
nv-morpheus:branch-25.06
from
dagardner-nv:david-py-312-2181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rpheus into david-25.02-x-25.02
…avid-25.02-x-25.02
…avid-rapids-25.02
…avid-rapids-25.02
…avid-rapids-25.02
…mount for apt, pip and conda
Cleanup DOCA env vars Remove redundant calls to `apt update`, remove call to `apt upgrade`. Fix download location for `doca-host.deb` Consolidate installing of doca packagwes
52c41c8
to
114e147
Compare
/ok to test |
Signed-off-by: Will Killian <[email protected]>
114e147
to
123a585
Compare
/ok to test |
Signed-off-by: Will Killian <[email protected]>
/ok to test |
1 similar comment
/ok to test |
Signed-off-by: Will Killian <[email protected]>
bb09517
to
2ca4c64
Compare
/ok to test |
Signed-off-by: Will Killian <[email protected]>
/ok to test |
Signed-off-by: Will Killian <[email protected]>
/ok to test |
Signed-off-by: David Gardner <[email protected]>
/ok to test |
Signed-off-by: Will Killian <[email protected]>
/ok to test |
Signed-off-by: Will Killian <[email protected]>
/ok to test |
Signed-off-by: Will Killian <[email protected]>
/ok to test |
willkill07
reviewed
Mar 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are additional comments to aid in the review of this PR.
Signed-off-by: David Gardner <[email protected]>
/ok to test |
Release container build doesn't work for me:
|
Signed-off-by: Will Killian <[email protected]>
/ok to test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking
Breaking change
conda-build
Enables running the conda-build step on a PR
dependencies
Pull requests that update a dependency file
feature request
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ImportError
-derived)faiss-cpu
on aarch64 target uses deprecated numpy API #2190 & upstream issuefaiss
fails to import on python==3.12 because of deprecatednumpy.distutils
facebookresearch/faiss#3936Closes #2181
By Submitting this PR I confirm: