Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix or silence warnings emitted during tests #1457

Closed
Show file tree
Hide file tree
Changes from 49 commits
Commits
Show all changes
51 commits
Select commit Hold shift + click to select a range
598a1db
Ignore deprecation warnings from gputil
dagardner-nv Dec 19, 2023
0dc1816
Suppress warnings from merlin/nvt regardning tensorflow not being ins…
dagardner-nv Dec 19, 2023
80575ca
Revert "Ignore deprecation warnings from gputil"
dagardner-nv Dec 19, 2023
7a722bb
Ignore distutils deprecation warning
dagardner-nv Dec 19, 2023
0d1fa37
Mark the http server tests as slow
dagardner-nv Dec 19, 2023
da692e8
Capture the warning emitted when timestamp is provided but timestamp …
dagardner-nv Dec 19, 2023
f1dcd44
Narrow the warning filters to be more specific, ensuring we aren't ac…
dagardner-nv Dec 29, 2023
374d6d6
Merge branch 'branch-24.03' of github.com:nv-morpheus/Morpheus into d…
dagardner-nv Dec 29, 2023
42614ec
Silence warnings about not having a config option
dagardner-nv Jan 6, 2024
074081e
Avoid warning from cudf regardning an upcoming change of behavior whe…
dagardner-nv Jan 6, 2024
3a822c7
Add comment explaining the special handling of single element lists
dagardner-nv Jan 6, 2024
3282475
WIP: need to find the root cause of this warning
dagardner-nv Jan 6, 2024
a226c17
Update CR Year
dagardner-nv Jan 8, 2024
907f7d7
Merge branch 'david-pytest-warnings' into david-pytest-warnings-p2
dagardner-nv Jan 8, 2024
a0bbee2
Add comment explaining the warning coming from numpy 1.26
dagardner-nv Jan 8, 2024
62915f5
Merge branch 'branch-24.03' of github.com:nv-morpheus/Morpheus into d…
dagardner-nv Jan 8, 2024
592f7f4
Update test for completion pipe to use actual asyncio futures, simila…
dagardner-nv Jan 9, 2024
032ddec
Avoid warning about setting values on a copy
dagardner-nv Jan 9, 2024
766d474
Ignore performance warnings from pandas triggered by the df compare m…
dagardner-nv Jan 9, 2024
5462726
Restrict numpy to versions prior to 1.25, this avoids numerous warnin…
dagardner-nv Jan 9, 2024
874776f
Silence warning about cudf's subword tokenizer behaving differently t…
dagardner-nv Jan 9, 2024
21d8562
Avoid pandas warning about setting a value on a copy
dagardner-nv Jan 9, 2024
03168a2
Ignore the warning from the logging_timer which happens whenever DFPS…
dagardner-nv Jan 9, 2024
062c214
Fix name of fixture resulting from bad copy/paste
dagardner-nv Jan 11, 2024
a29cece
Replace deprecated usage of is_monotonic attribute with is_monotonic_…
dagardner-nv Jan 11, 2024
5154135
Replace usage of deprecated on_start method in monitor stage
dagardner-nv Jan 11, 2024
e188d3a
Replace usage of deprecated on_start method in HttpServerSinkStage
dagardner-nv Jan 11, 2024
71c7475
Update test to assert that a deprecation warning for on_start is prod…
dagardner-nv Jan 11, 2024
90c79f5
Silence warning regarding tensorflow not being installed from nvt/merlin
dagardner-nv Jan 11, 2024
cb66ea0
avoid deprecation warning about using .astype to convert from a tz-aw…
dagardner-nv Jan 12, 2024
0913d14
Avoid cudf warning that reading a json file uses pandas, create fixtu…
dagardner-nv Jan 12, 2024
07ea3fd
Ignore warning about an existing dask client, as we are explicitly co…
dagardner-nv Jan 12, 2024
b4b1df2
Ignore cudf warnings about Pandas being used under the hood for proce…
dagardner-nv Jan 12, 2024
d88d5ef
Ignore warning that is only produced when calling with an abnormally …
dagardner-nv Jan 12, 2024
45a92e6
Adopt dgl v1.1.1 to pickup pytorch v2.0.1 support. Add rapids-depende…
dagardner-nv Jan 12, 2024
12b71c3
Specify a version for sysroot_linux-64, without this I was getting ou…
dagardner-nv Jan 10, 2024
b5562fa
Switch to using conda to fetch pyarrow-hotfix
dagardner-nv Jan 9, 2024
e07b1c6
Ensure we receive a cuda enabled build of pyarrow
dagardner-nv Jan 12, 2024
82ca88b
update CR
dagardner-nv Jan 12, 2024
95748a4
lint fixes
dagardner-nv Jan 12, 2024
02c74fb
formatting
dagardner-nv Jan 12, 2024
1347cb3
lint fixes
dagardner-nv Jan 12, 2024
6891868
Fix fixture names
dagardner-nv Jan 12, 2024
9d955a6
Merge branch 'branch-24.03' of github.com:nv-morpheus/Morpheus into d…
dagardner-nv Jan 12, 2024
05db11f
Ignore warnings generated by the kafka fixtures themselves, but not t…
dagardner-nv Jan 12, 2024
27c0a18
Fix CR
dagardner-nv Jan 12, 2024
f6eaab4
Don't mock asyncio.gather because it is also used by jinja
dagardner-nv Jan 12, 2024
a973eb2
Set max_batch_size to match model's max_batch_size
dagardner-nv Jan 12, 2024
c7eecae
Update CR
dagardner-nv Jan 12, 2024
0ab58d6
Merge branch 'branch-24.03' into david-pytest-warnings-p2
dagardner-nv Jan 17, 2024
2169ad3
Rename fixture methods to conform to a _fixture suffix
dagardner-nv Jan 17, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ci/conda/recipes/morpheus/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ outputs:
- pandas 1.3.*
- pluggy 1.0.*
- pyarrow * *_cuda # Ensure we get a CUDA build. Version determined by cuDF
- pyarrow-hotfix # CVE-2023-47248
- python
- python-confluent-kafka 1.9.2
- pytorch 2.0.1
Expand Down
24 changes: 17 additions & 7 deletions conda/environments/all_cuda-118_arch-x86_64.yaml
Original file line number Diff line number Diff line change
@@ -1,14 +1,13 @@
# This file is generated by `rapids-dependency-file-generator`.
# To make changes, edit ../../dependencies.yaml and run `rapids-dependency-file-generator`.
# To make changes, edit dependencies.yaml and run `rapids-dependency-file-generator`.
channels:
- conda-forge
- huggingface
- rapidsai
- nvidia/label/cuda-11.8.0
- nvidia
- rapidsai-nightly
- nvidia/label/dev
- huggingface
- pytorch
- conda-forge
- dglteam/label/cu118
dependencies:
- appdirs
Expand All @@ -17,6 +16,8 @@ dependencies:
- boost-cpp=1.82
- boto3
- breathe=4.34.0
- cachetools=5.0.0
- ccache>=3.7
- clangdev=16
- click >=8
- click>=8
Expand All @@ -34,7 +35,7 @@ dependencies:
- cython=0.29.24
- dask>=2023.1.1
- datacompy=0.8
- dgl=1.0.2
- dgl=1.1.1
- dill
- dill=0.3.6
- distributed>=2023.1.1
Expand All @@ -52,6 +53,7 @@ dependencies:
- include-what-you-use=0.20
- ipython
- isort
- kafka-python=2.0
- langchain=0.0.190
- librdkafka=1.9.2
- libwebp>=1.3.2
Expand All @@ -65,14 +67,20 @@ dependencies:
- ninja=1.10
- nlohmann_json=3.9
- nodejs=18.*
- numpy>=1.21,<1.25
- numpydoc=1.4
- nvtabular=23.06
- openai=0.28
- pandas=1.3
- papermill=2.3.4
- pip
- pluggy=1.0
- port-for=0.7
- pre-commit
- protobuf=4.21.*
- py4j=0.10
- pyarrow * *_cuda
- pyarrow-hotfix
- pybind11-stubgen=0.10
- pylint>=2.17.4,<2.18
- pypdf=3.16
Expand All @@ -94,6 +102,7 @@ dependencies:
- sphinx
- sphinx_rtd_theme
- sqlalchemy<2.0
- sysroot_linux-64=2.17
- tqdm=4
- transformers=4.30.2
- tritonclient=2.26
Expand All @@ -109,7 +118,8 @@ dependencies:
- grpcio-status==1.58
- milvus==2.3.2
- nemollm
- pyarrow_hotfix
- pymilvus==2.3.2
- pytest-kafka==0.6.0
name: all_cuda-118_arch-x86_64
- rapids-dependency-file-generator
name: all_cuda-118_arch-x86_64_py-310

22 changes: 16 additions & 6 deletions conda/environments/dev_cuda-118_arch-x86_64.yaml
Original file line number Diff line number Diff line change
@@ -1,20 +1,21 @@
# This file is generated by `rapids-dependency-file-generator`.
# To make changes, edit ../../dependencies.yaml and run `rapids-dependency-file-generator`.
# To make changes, edit dependencies.yaml and run `rapids-dependency-file-generator`.
channels:
- conda-forge
- huggingface
- rapidsai
- nvidia/label/cuda-11.8.0
- nvidia
- rapidsai-nightly
- nvidia/label/dev
- huggingface
- pytorch
- conda-forge
- dglteam/label/cu118
dependencies:
- appdirs
- benchmark=1.6.0
- boost-cpp=1.82
- breathe=4.34.0
- cachetools=5.0.0
- ccache>=3.7
- clangdev=16
- click >=8
- click>=8
Expand Down Expand Up @@ -43,6 +44,7 @@ dependencies:
- include-what-you-use=0.20
- ipython
- isort
- kafka-python=2.0
- librdkafka=1.9.2
- mlflow>=2.2.1,<3
- mrc=24.03
Expand All @@ -52,12 +54,18 @@ dependencies:
- ninja=1.10
- nlohmann_json=3.9
- nodejs=18.*
- numpy>=1.21,<1.25
- numpydoc=1.4
- nvtabular=23.06
- pandas=1.3
- pip
- pluggy=1.0
- port-for=0.7
- pre-commit
- protobuf=4.21.*
- py4j=0.10
- pyarrow * *_cuda
- pyarrow-hotfix
- pybind11-stubgen=0.10
- pylint>=2.17.4,<2.18
- pytest
Expand All @@ -75,6 +83,7 @@ dependencies:
- sphinx
- sphinx_rtd_theme
- sqlalchemy<2.0
- sysroot_linux-64=2.17
- tqdm=4
- tritonclient=2.26
- typing_utils=0.1
Expand All @@ -85,7 +94,8 @@ dependencies:
- pip:
- databricks-connect
- milvus==2.3.2
- pyarrow_hotfix
- pymilvus==2.3.2
- pytest-kafka==0.6.0
name: dev_cuda-118_arch-x86_64
- rapids-dependency-file-generator
name: dev_cuda-118_arch-x86_64_py-310

28 changes: 23 additions & 5 deletions dependencies.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -107,14 +107,13 @@ files:


channels:
- conda-forge
- huggingface
- rapidsai
- nvidia/label/cuda-11.8.0
- nvidia
- rapidsai-nightly
- nvidia/label/dev
- huggingface
- pytorch
- conda-forge
- dglteam/label/cu118

dependencies:
Expand All @@ -126,6 +125,8 @@ dependencies:
- mrc=24.03 # should this be in build, or somewhere else?
- gcc_linux-64=11.2
- gxx_linux-64=11.2
- cachetools=5.0.0
- ccache>=3.7
- cmake=3.25
- boost-cpp=1.82
- cuda-nvcc
Expand All @@ -135,10 +136,14 @@ dependencies:
- librdkafka=1.9.2
- ninja=1.10
- nlohmann_json=3.9
- pandas=1.3
- protobuf=4.21.*
- pyarrow * *_cuda # Ensure we get a CUDA build. Version determined by cuDF
- pyarrow-hotfix
- pybind11-stubgen=0.10
- rapidjson=1.1.0
- scikit-build=0.17.1
- sysroot_linux-64=2.17
- tritonclient=2.26 # Required by NvTabular, force the version, so we get protobufs compatible with 4.21
- ucx=1.14

Expand All @@ -164,6 +169,9 @@ dependencies:
- isort
- pylint>=2.17.4,<2.18 # 2.17.4 contains a fix for toml support
- yapf=0.40.1
- pip
- pip:
- rapids-dependency-file-generator

docs:
common:
Expand Down Expand Up @@ -196,7 +204,7 @@ dependencies:
- boto3
- cuml=23.06
- dask>=2023.1.1
- dgl=1.0.2
- dgl=1.1.1
- dill=0.3.6
- distributed>=2023.1.1
- huggingface_hub=0.10.1 # work-around for https://github.com/UKPLab/sentence-transformers/issues/1762
Expand Down Expand Up @@ -238,8 +246,12 @@ dependencies:
- grpcio
- mlflow>=2.2.1,<3
- nb_conda_kernels
# Avoids numerous warnings triggered by cudf, recent versions of cudf impost this version requirement
- numpy>=1.21,<1.25
- numpydoc=1.4
- nvtabular=23.06
- pyarrow * *_cuda # Ensure we get a CUDA build. Version determined by cuDF
- pyarrow-hotfix
- python-confluent-kafka=1.9.2
- python-graphviz
- pytorch-cuda
Expand All @@ -251,11 +263,17 @@ dependencies:
- typing_utils=0.1
- watchdog=2.1
- websockets

####### Pip Transitive Dependencies (keep sorted!) #######
# These are dependencies that are available on conda, but are required by the pip packages listed below. Its much
# better to install them with conda than pip to allow for better dependency resolution.
- kafka-python=2.0
- port-for=0.7
- py4j=0.10
- pip
- pip:
- databricks-connect
- milvus==2.3.2
- pyarrow_hotfix
- pymilvus==2.3.2

test_python_morpheus:
Expand Down
4 changes: 3 additions & 1 deletion docker/conda/environments/cuda11.8_dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,8 @@ dependencies:
- ninja=1.10
- nodejs=18.*
- numba>=0.56.2
# Avoids numerous warnings triggered by cudf, recent versions of cudf impost this version
- numpy>=1.21,<1.25
- numpydoc=1.4
- nvtabular=23.06
- pandas=1.3
Expand All @@ -82,6 +84,7 @@ dependencies:
- pluggy=1.0
- protobuf=4.21.*
- pyarrow * *_cuda # Ensure we get a CUDA build. Version determined by cuDF
- pyarrow-hotfix # CVE-2023-47248. See morpheus/__init__.py for more details
- pybind11-stubgen=0.10.5
- pydot
- pylint>=2.17.4,<2.18 # 2.17.4 contains a fix for toml support
Expand Down Expand Up @@ -123,6 +126,5 @@ dependencies:
# Add additional dev dependencies here
- databricks-connect
- milvus==2.3.2
- pyarrow_hotfix # CVE-2023-47248. See morpheus/__init__.py for more details
- pymilvus==2.3.2
- pytest-kafka==0.6.0
4 changes: 2 additions & 2 deletions docker/conda/environments/cuda11.8_examples.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# SPDX-FileCopyrightText: Copyright (c) 2022-2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# SPDX-FileCopyrightText: Copyright (c) 2022-2024, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# SPDX-License-Identifier: Apache-2.0
#
# Licensed under the Apache License, Version 2.0 (the "License");
Expand Down Expand Up @@ -32,7 +32,7 @@ dependencies:
- boto3
- cuml=23.06
- dask>=2023.1.1
- dgl=1.0.2
- dgl=1.1.1
- dill=0.3.6
- distributed>=2023.1.1
- huggingface_hub=0.10.1 # work-around for https://github.com/UKPLab/sentence-transformers/issues/1762
Expand Down
4 changes: 2 additions & 2 deletions examples/gnn_fraud_detection_pipeline/requirements.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# SPDX-FileCopyrightText: Copyright (c) 2022-2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# SPDX-FileCopyrightText: Copyright (c) 2022-2024, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# SPDX-License-Identifier: Apache-2.0
#
# Licensed under the Apache License, Version 2.0 (the "License");
Expand All @@ -21,4 +21,4 @@ channels:
- defaults
dependencies:
- cuml=23.06
- dgl=1.0.2
- dgl=1.1.1
4 changes: 2 additions & 2 deletions examples/llm/vdb_upload/run.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright (c) 2023, NVIDIA CORPORATION.
# Copyright (c) 2023-2024, NVIDIA CORPORATION.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -46,7 +46,7 @@ def run():
)
@click.option(
"--model_max_batch_size",
default=64,
default=256,
type=click.IntRange(min=1),
help="Max batch size to use for the model",
)
Expand Down
5 changes: 3 additions & 2 deletions morpheus/_lib/src/objects/table_info.cpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* SPDX-FileCopyrightText: Copyright (c) 2021-2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
* SPDX-FileCopyrightText: Copyright (c) 2021-2024, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
* SPDX-License-Identifier: Apache-2.0
*
* Licensed under the Apache License, Version 2.0 (the "License");
Expand Down Expand Up @@ -300,7 +300,8 @@ std::optional<std::string> MutableTableInfo::ensure_sliceable_index()
auto df_index = py_df.attr("index");

// Check to see if we actually need the change
if (df_index.attr("is_unique").cast<bool>() && df_index.attr("is_monotonic").cast<bool>())
if (df_index.attr("is_unique").cast<bool>() && (df_index.attr("is_monotonic_increasing").cast<bool>() ||
df_index.attr("is_monotonic_decreasing").cast<bool>()))
{
// Set the outputname to nullopt
old_index_col_name = std::nullopt;
Expand Down
4 changes: 2 additions & 2 deletions morpheus/stages/general/monitor_stage.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright (c) 2021-2023, NVIDIA CORPORATION.
# Copyright (c) 2021-2024, NVIDIA CORPORATION.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -99,7 +99,7 @@ def accepted_types(self) -> typing.Tuple:
def supports_cpp_node(self):
return False

def on_start(self):
async def start_async(self):
"""
Starts the pipeline stage's progress bar.
"""
Expand Down
4 changes: 2 additions & 2 deletions morpheus/stages/output/http_server_sink_stage.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright (c) 2021-2023, NVIDIA CORPORATION.
# Copyright (c) 2021-2024, NVIDIA CORPORATION.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -142,7 +142,7 @@ def supports_cpp_node(self):
"""Indicates whether or not this stage supports a C++ node."""
return False

def on_start(self):
async def start_async(self):
"""Starts the HTTP server."""
from morpheus.common import HttpServer
self._server = HttpServer(parse_fn=self._request_handler,
Expand Down
Loading
Loading