fix: validate modules on sync #864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, if an exception is thrown while syncing a module, it's just silently ignored. So a part of this PR is enabling visibility on these exceptions being thrown.
Once I could see the exceptions, it turned out a bunch of the modules were broken for the GitHub repo link, which I fixed up.
I added validation for
websiteandlearn_moreso that we're not adding 404 links to the nuxt.com site. There were a bunch of broken links which I have fixed up.Lastly, it seems there were some broken icon paths.