Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(add,init): improve default ux #737

Merged
merged 5 commits into from
Feb 13, 2025
Merged

fix(add,init): improve default ux #737

merged 5 commits into from
Feb 13, 2025

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

slightly improve default UX

CleanShot 2025-02-11 at 15 56 22@2x

would also be nice to be able to render nuxt logo as an image but in my testing it was too detailed to render well at a small size, and making it large made it somewhat overwhelming

@danielroe danielroe added the enhancement New feature or request label Feb 11, 2025
@danielroe danielroe requested a review from atinux February 11, 2025 15:57
@danielroe danielroe self-assigned this Feb 11, 2025
Copy link
Contributor

github-actions bot commented Feb 11, 2025

Bundle Stats β€” nuxt-cli size comparison

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
29 78.79 kB β†’ 79.34 kB (+561 B) +0.70%
Changeset
File Ξ” Size
home/runner/work/cli/cli/packages/nuxi/src/utils/ascii.ts πŸ†• +228 B 0 B β†’ 228 B
home/runner/work/cli/cli/packages/nuxi/src/utils/logger.ts πŸ“ˆ +57 B (+146.15%) 39 B β†’ 96 B
home/runner/work/cli/cli/packages/nuxi/src/main.ts πŸ“ˆ +94 B (+8.43%) 1.09 kB β†’ 1.18 kB
home/runner/work/cli/cli/packages/nuxi/src/commands/init.ts πŸ“ˆ +207 B (+3.90%) 5.19 kB β†’ 5.39 kB
home/runner/work/cli/cli/packages/nuxi/src/commands/module/add.ts πŸ“ˆ +9 B (+0.09%) 10.17 kB β†’ 10.17 kB
package.json πŸ“‰ -29 B (-25.89%) 112 B β†’ 83 B
home/runner/work/cli/cli/packages/nuxi/package.json πŸ“‰ -29 B (-27.10%) 107 B β†’ 78 B
View detailed bundle breakdown

Added

Asset File Size % Changed
shared/cli.BlRB3DZQ.mjs 0 B β†’ 5.5 kB (+5.5 kB) -
shared/cli.Be8tlMIk.mjs 0 B β†’ 1.23 kB (+1.23 kB) -
shared/cli.Ci3951v3.mjs 0 B β†’ 836 B (+836 B) -
shared/cli.BAwo9lPr.mjs 0 B β†’ 804 B (+804 B) -
shared/cli.CtXqLDQa.mjs 0 B β†’ 294 B (+294 B) -
shared/cli.xeQT2QTr.mjs 0 B β†’ 78 B (+78 B) -

Removed

Asset File Size % Changed
shared/cli.RaLbArMx.mjs 5.48 kB β†’ 0 B (-5.48 kB) -100%
shared/cli.BTZUH2Zx.mjs 1.23 kB β†’ 0 B (-1.23 kB) -100%
shared/cli.DsRZukXv.mjs 836 B β†’ 0 B (-836 B) -100%
shared/cli.CMnxGfjW.mjs 804 B β†’ 0 B (-804 B) -100%
shared/cli.BBMBFmD2.mjs 294 B β†’ 0 B (-294 B) -100%
shared/cli.DaI-EKv1.mjs 107 B β†’ 0 B (-107 B) -100%

Bigger

Asset File Size % Changed
chunks/add2.mjs 11.83 kB β†’ 12.15 kB (+331 B) +2.73%
chunks/init.mjs 5.19 kB β†’ 5.39 kB (+207 B) +3.90%
index.mjs 200 B β†’ 224 B (+24 B) +12.00%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
chunks/add.mjs 6.83 kB 0%
chunks/analyze.mjs 3.18 kB 0%
chunks/build.mjs 1.97 kB 0%
chunks/cleanup.mjs 471 B 0%
chunks/dev-child.mjs 1.95 kB 0%
chunks/dev.mjs 7.2 kB 0%
chunks/devtools.mjs 763 B 0%
chunks/generate.mjs 388 B 0%
chunks/info.mjs 4.39 kB 0%
chunks/index.mjs 274 B 0%
chunks/prepare.mjs 984 B 0%
chunks/preview.mjs 2.84 kB 0%
chunks/test.mjs 1.16 kB 0%
chunks/typecheck.mjs 1.74 kB 0%
chunks/upgrade.mjs 6.27 kB 0%
chunks/dev2.mjs 7.78 kB 0%
chunks/search.mjs 2.94 kB 0%
shared/cli.BSm0_9Hr.mjs 107 B 0%
shared/cli.DlcAx0De.mjs 1.04 kB 0%
shared/cli.C935N1ss.mjs 687 B 0%

Copy link
Contributor

github-actions bot commented Feb 11, 2025

Bundle Stats β€” nuxi size comparison

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
51 5.65 MB β†’ 5.66 MB (+561 B) +0.01%
Changeset
File Ξ” Size
node_modules/pathe/dist/shared/pathe.UZ-hd4nF.mjs πŸ†• +5.46 kB 0 B β†’ 5.46 kB
src/utils/ascii.ts πŸ†• +228 B 0 B β†’ 228 B
src/utils/logger.ts πŸ“ˆ +57 B (+146.15%) 39 B β†’ 96 B
src/main.ts πŸ“ˆ +89 B (+7.86%) 1.11 kB β†’ 1.19 kB
src/commands/init.ts πŸ“ˆ +207 B (+3.88%) 5.21 kB β†’ 5.41 kB
src/commands/module/add.ts πŸ“ˆ +9 B (+0.09%) 10.18 kB β†’ 10.19 kB
package.json πŸ“‰ -29 B (-27.10%) 107 B β†’ 78 B
node_modules/pathe/dist/shared/pathe.M-eThtNZ.mjs πŸ”₯ -5.46 kB (-100%) 5.46 kB β†’ 0 B
View detailed bundle breakdown

Added

Asset File Size % Changed
shared/nuxi.CVciKQ9h.mjs 0 B β†’ 76.38 kB (+76.38 kB) -
shared/nuxi.D5wUDCkl.mjs 0 B β†’ 17.66 kB (+17.66 kB) -
shared/nuxi.BtUHPN_q.mjs 0 B β†’ 836 B (+836 B) -
shared/nuxi.9reeQ2f7.mjs 0 B β†’ 804 B (+804 B) -
shared/nuxi.CLQUHpa_.mjs 0 B β†’ 294 B (+294 B) -

Removed

Asset File Size % Changed
shared/nuxi.D1shwc5e.mjs 76.04 kB β†’ 0 B (-76.04 kB) -100%
shared/nuxi.Qu3xUiyP.mjs 17.66 kB β†’ 0 B (-17.66 kB) -100%
shared/nuxi.BLhj92eK.mjs 836 B β†’ 0 B (-836 B) -100%
shared/nuxi.DkhvWudn.mjs 804 B β†’ 0 B (-804 B) -100%
shared/nuxi.EhLNCsDq.mjs 294 B β†’ 0 B (-294 B) -100%

Bigger

Asset File Size % Changed
chunks/init.mjs 795.52 kB β†’ 795.73 kB (+207 B) +0.03%
chunks/add2.mjs 12.02 kB β†’ 12.03 kB (+9 B) +0.07%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
index.mjs 188 B 0%
chunks/prompt.mjs 42.92 kB 0%
chunks/add.mjs 6.83 kB 0%
chunks/analyze.mjs 3.18 kB 0%
chunks/build.mjs 1.97 kB 0%
chunks/cleanup.mjs 471 B 0%
chunks/dev-child.mjs 1.94 kB 0%
chunks/dev.mjs 9.81 kB 0%
chunks/devtools.mjs 764 B 0%
chunks/generate.mjs 388 B 0%
chunks/info.mjs 4.39 kB 0%
chunks/index.mjs 274 B 0%
chunks/prepare.mjs 984 B 0%
chunks/preview.mjs 2.84 kB 0%
chunks/test.mjs 1.16 kB 0%
chunks/typecheck.mjs 1.74 kB 0%
chunks/upgrade.mjs 6.27 kB 0%
chunks/satisfies.mjs 116 B 0%
chunks/main.mjs 15.3 kB 0%
chunks/index2.mjs 934.15 kB 0%
chunks/dev2.mjs 69.62 kB 0%
chunks/index3.mjs 17.14 kB 0%
chunks/xdg-open.mjs 25.32 kB 0%
chunks/node.mjs 134.28 kB 0%
chunks/index4.mjs 1.23 kB 0%
chunks/index5.mjs 71.77 kB 0%
chunks/multipart-parser.mjs 5.11 kB 0%
chunks/search.mjs 45.83 kB 0%
chunks/index6.mjs 5.85 kB 0%
chunks/index7.mjs 885.9 kB 0%
chunks/multipart-parser2.mjs 4.58 kB 0%
shared/nuxi.D2_bzAv0.mjs 1.54 kB 0%
shared/nuxi.BSm0_9Hr.mjs 107 B 0%
shared/nuxi.CdLKTWzs.mjs 1.34 kB 0%
shared/nuxi.HiGHWrR5.mjs 14.63 kB 0%
shared/nuxi.Cx_HAvUZ.mjs 9.65 kB 0%
shared/nuxi.BxQQOHdn.mjs 2.02 MB 0%
shared/nuxi.E-ZsRS8r.mjs 943 B 0%
shared/nuxi.BjhZEm2-.mjs 1.75 kB 0%
shared/nuxi.DcHCnhdt.mjs 151.1 kB 0%
shared/nuxi.Bu_55mY6.mjs 284.98 kB 0%
shared/nuxi.D4vggcPe.mjs 5.7 kB 0%
shared/nuxi.Do0aYBCO.mjs 5.46 kB 0%
shared/nuxi.Dka9C7kP.mjs 43.55 kB 0%

Copy link
Contributor

github-actions bot commented Feb 11, 2025

Bundle Stats β€” create-nuxt-app size comparison

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
5 975.95 kB β†’ 976.21 kB (+264 B) +0.03%
Changeset
File Ξ” Size
node_modules/pathe/dist/shared/pathe.UZ-hd4nF.mjs πŸ†• +5.27 kB 0 B β†’ 5.27 kB
home/runner/work/cli/cli/packages/nuxi/src/utils/logger.ts πŸ“ˆ +57 B (+146.15%) 39 B β†’ 96 B
home/runner/work/cli/cli/packages/nuxi/src/commands/init.ts πŸ“ˆ +207 B (+3.88%) 5.21 kB β†’ 5.41 kB
node_modules/pathe/dist/shared/pathe.M-eThtNZ.mjs πŸ”₯ -5.27 kB (-100%) 5.27 kB β†’ 0 B
View detailed bundle breakdown

Added

Asset File Size % Changed
shared/create-nuxt-app.D3PeqJFj.mjs 0 B β†’ 883.49 kB (+883.49 kB) -

Removed

Asset File Size % Changed
shared/create-nuxt-app.BP0BfCTp.mjs 883.23 kB β†’ 0 B (-883.23 kB) -100%

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
index.mjs 1.03 kB 0%
chunks/multipart-parser.mjs 5.11 kB 0%
chunks/prompt.mjs 42.92 kB 0%
chunks/satisfies.mjs 43.66 kB 0%

Copy link

pkg-pr-new bot commented Feb 11, 2025

Open in Stackblitz

npm i https://pkg.pr.new/create-nuxt-app@737
npm i https://pkg.pr.new/nuxi@737
npm i https://pkg.pr.new/@nuxt/cli@737

commit: a93a684

@danielroe danielroe merged commit 53cdbfe into main Feb 13, 2025
11 checks passed
@danielroe danielroe deleted the fix/colors branch February 13, 2025 19:51
This was referenced Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants