Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(preview): add --port option for previewing #724

Merged
merged 5 commits into from
Feb 13, 2025
Merged

Conversation

Saeid-Za
Copy link
Contributor

@Saeid-Za Saeid-Za commented Feb 3, 2025

πŸ”— Linked issue

resolves #721

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR adds --port, -p option to preview command, for it to be consistent with dev command an a little better DX in compared to providing an environment variable.

@Saeid-Za Saeid-Za requested a review from danielroe as a code owner February 3, 2025 09:40
Copy link

pkg-pr-new bot commented Feb 13, 2025

Open in Stackblitz

npm i https://pkg.pr.new/create-nuxt-app@724
npm i https://pkg.pr.new/@nuxt/cli@724
npm i https://pkg.pr.new/nuxi@724

commit: 46304ca

@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 4.00000% with 24 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@b8281cb). Learn more about missing BASE report.

Files with missing lines Patch % Lines
packages/nuxi/src/commands/preview.ts 4.00% 24 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #724   +/-   ##
=======================================
  Coverage        ?   13.48%           
=======================================
  Files           ?       66           
  Lines           ?     3374           
  Branches        ?       96           
=======================================
  Hits            ?      455           
  Misses          ?     2889           
  Partials        ?       30           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@danielroe danielroe changed the title feat: adding port option to preview command feat(preview): adding port option Feb 13, 2025
@danielroe danielroe changed the title feat(preview): adding port option feat(preview): add --port option for previewing Feb 13, 2025
@danielroe danielroe merged commit 4b0ebd8 into nuxt:main Feb 13, 2025
8 of 11 checks passed
@danielroe
Copy link
Member

Thank you ❀️

This was referenced Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Expose more arguments in preview command
4 participants