Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dev): enable fork for bun >=1.2 #723

Merged
merged 3 commits into from
Feb 13, 2025
Merged

feat(dev): enable fork for bun >=1.2 #723

merged 3 commits into from
Feb 13, 2025

Conversation

Saeid-Za
Copy link
Contributor

@Saeid-Za Saeid-Za commented Feb 2, 2025

πŸ”— Linked issue

resolves #722

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Enabling fork mode if bun version > 1.2.x

@Saeid-Za Saeid-Za requested a review from danielroe as a code owner February 2, 2025 13:13
@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2025

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@b8281cb). Learn more about missing BASE report.

Files with missing lines Patch % Lines
packages/nuxi/src/commands/dev.ts 0.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #723   +/-   ##
=======================================
  Coverage        ?   13.52%           
=======================================
  Files           ?       66           
  Lines           ?     3356           
  Branches        ?       96           
=======================================
  Hits            ?      454           
  Misses          ?     2871           
  Partials        ?       31           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

Copy link

pkg-pr-new bot commented Feb 2, 2025

Open in Stackblitz

npm i https://pkg.pr.new/create-nuxt-app@723
npm i https://pkg.pr.new/@nuxt/cli@723
npm i https://pkg.pr.new/nuxi@723

commit: 5876687

@danielroe
Copy link
Member

Thank you ❀️

@danielroe danielroe changed the title feat(dev): enable fork for bun conditionally feat(dev): enable fork for bun >=1.2 Feb 13, 2025
@danielroe danielroe merged commit d134c03 into nuxt:main Feb 13, 2025
8 of 11 checks passed
@github-actions github-actions bot mentioned this pull request Feb 13, 2025
@Saeid-Za Saeid-Za deleted the bun branch February 15, 2025 16:37
@github-actions github-actions bot mentioned this pull request Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable fork-mode in bun
3 participants