Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add additional information to the documentation #431

Merged
merged 9 commits into from
Jul 27, 2023

Conversation

Jamiewarb
Copy link
Contributor

@Jamiewarb Jamiewarb commented Jul 26, 2023

This PR adds additional information to the documentation. It aims to expand on what was already there, adding further information, examples, and links, as well as provide new information and best practices for developing with Nuxt and Ionic.

image

It provides an architecture for categorising pages and for adding more later, covering "Get Started", "Overview" and "Cookbook".

Getting Started covers users who are looking to get to grips with the project in their application. It covers a module intro, installation, configuration, setting up Capacitor, and watch outs for those new to Ionic.

Overview goes more into the detail of what the module is doing under the hood, and has some information on how to use some of its features. It covers Routing, Theming, Auto-imports, Module components/utilities, Icons and Deployment.

Cookbook is an example-heavy section for common use cases. It can include things outside of the scope of the module, but that users will find helpful as they use this module.

Most sections link out to vue, nuxt, ionic or capacitor documentation, allowing the user to further expand their knowledge on these sections if they wish, or it links to relevant pages within the modules own documentation.

Happy to make any and all changes as required, and hope that it's the beginning of helping clean up some of the questions people have been having.

#6 - I've added a cookbook page for this, though we should look to refine it further and make sure we're completely happy
#42 - Can possibly close this, as it's covered by the Introduction section? Let me know if you think further info should be added to cover this
#121 - This issue and workaround is now mentioned in the Watchouts section

Closes #56 - This is now covered in the "Deploying" section, and links out to the Ionic docs
Closes #231 - This is thoroughly covered in the "Routing" section of the docs
Closes #197 - This is now covered in the "Routing" section and "Watchouts" section
Closes #425 - This is covered in docs through several mentions of ssr: false in Installation and in "Watchouts" section

@nuxt-studio
Copy link

nuxt-studio bot commented Jul 26, 2023

Live Preview ready!

Name Edit Preview Latest Commit
Ionic Edit on Studio ↗︎ View Live Preview 8429f57

@netlify
Copy link

netlify bot commented Jul 26, 2023

Deploy Preview for friendly-lamington-fb5690 canceled.

Name Link
🔨 Latest commit 8429f57
🔍 Latest deploy log https://app.netlify.com/sites/friendly-lamington-fb5690/deploys/64c274bdc3af5400083268f2

@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2023

Codecov Report

Merging #431 (8429f57) into main (481b4de) will increase coverage by 0.40%.
The diff coverage is 0.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #431      +/-   ##
==========================================
+ Coverage   82.96%   83.36%   +0.40%     
==========================================
  Files           9        9              
  Lines         493      493              
  Branches       30       30              
==========================================
+ Hits          409      411       +2     
+ Misses         84       82       -2     
Files Changed Coverage Δ
src/module.ts 74.33% <0.00%> (+0.88%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@danielroe danielroe merged commit 2d40e84 into nuxt-modules:main Jul 27, 2023
@Jamiewarb
Copy link
Contributor Author

🎉

@Jamiewarb Jamiewarb deleted the docs/information-expansion branch July 27, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants