Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check if resolved localized route name exists #3325

Conversation

BobbieGoede
Copy link
Collaborator

@BobbieGoede BobbieGoede commented Jan 23, 2025

๐Ÿ”— Linked issue

โ“ Type of change

  • ๐Ÿ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • ๐Ÿž Bug fix (a non-breaking change that fixes an issue)
  • ๐Ÿ‘Œ Enhancement (improving an existing functionality like performance)
  • โœจ New feature (a non-breaking change that adds functionality)
  • ๐Ÿงน Chore (updates to the build process or auxiliary tools and libraries)
  • โš ๏ธ Breaking change (fix or feature that would cause existing functionality to change)

๐Ÿ“š Description

Resolves #3321

This changes route resolution, we now check if a route exists with the localization suffix, if it doesn't it may be a route with localization disabled.

We may need to invert this conditional, check if a route exists without the localization suffix and otherwise proceed with the locale suffix, to ensure localized catchall/404 handling.

๐Ÿ“ Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

@BobbieGoede BobbieGoede self-assigned this Jan 23, 2025
Copy link

pkg-pr-new bot commented Jan 23, 2025

Open in Stackblitz

npm i https://pkg.pr.new/@nuxtjs/i18n@3325

commit: 2b26675

@BobbieGoede BobbieGoede merged commit 8b42ea7 into nuxt-modules:main Jan 23, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong routing with catch all route and a route localization disabled
1 participant