Add autoplay, autoplayMode and playinline to CldVideoPlayer #244
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Autoplay seemed to not work correctly because some props were missing. Adding autoPlay, playsinline and autoPlayMode as props resolved the problem
Types of changes
Description
I added the followings props to CldVideoPlayer:
I changed autoplayMode from a string to a union of the possible values.
Made also autoplayMode default value
always
so videos autoPlay correctly just by passing autoPlay = true.Resolves:#242
Checklist: