Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(blob): use ensure option if present #324

Merged
merged 2 commits into from
Oct 15, 2024
Merged

fix(blob): use ensure option if present #324

merged 2 commits into from
Oct 15, 2024

Conversation

johannschopplich
Copy link
Contributor

@johannschopplich johannschopplich commented Oct 15, 2024 •
edited
Loading

This PR servers two purposes; both fixing type issues:

  • The option maxSize and types are not part of BlobUploadOptions, but are used. Instead, the ensure option should be used to correctly allow ensuring a blob size/type.
  • Adds the missing R2Object type to the import statement from the @cloudflare/workers-types/experimental module. Otherwise, R2Object is resolved to any (currently).

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Oct 15, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/nuxt-hub/core/@nuxthub/core@324

commit: 347d5b4

@atinux atinux merged commit 47753b4 into nuxt-hub:main Oct 15, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atinux atinux atinux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johannschopplich @atinux