Ensure deprecationReason is set for arguments

nuwave · Sep 2, 2024 · e6210f7 · e6210f7
1 parent e3ba8f0
commit e6210f7
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,6 +9,9 @@ You can find and compare releases at the [GitHub release page](https://github.co
 
 ## Unreleased
 
+### Fixed
+- Ensure `deprecationReason` is set on arguments and input fields https://github.com/nuwave/lighthouse/pull/2609
+
 ## v6.44.0
 
 ### Added

diff --git a/src/Schema/AST/ASTHelper.php b/src/Schema/AST/ASTHelper.php
@@ -327,7 +327,7 @@ public static function qualifiedArgType(
     }
 
     /** Given a collection of directives, returns the string value for the deprecation reason. */
-    public static function deprecationReason(EnumValueDefinitionNode|FieldDefinitionNode $node): ?string
+    public static function deprecationReason(EnumValueDefinitionNode|FieldDefinitionNode|InputValueDefinitionNode $node): ?string
     {
         $deprecated = Values::getDirectiveValues(
             DirectiveDefinition::deprecatedDirective(),

diff --git a/src/Schema/Factories/ArgumentFactory.php b/src/Schema/Factories/ArgumentFactory.php
@@ -50,6 +50,7 @@ public function convert(InputValueDefinitionNode $definitionNode): array
             'name' => $definitionNode->name->value,
             'description' => $definitionNode->description?->value,
             'type' => $type,
+            'deprecationReason' => ASTHelper::deprecationReason($definitionNode),
             'astNode' => $definitionNode,
         ];