Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E: action doesn't fail when the container cleanup step fails #3650

Merged
merged 1 commit into from
Jan 10, 2025
Merged

E2E: action doesn't fail when the container cleanup step fails #3650

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/e2e-tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3

- name: Login to Docker Hub
- name: Login to ghcr.io
uses: docker/login-action@v3
with:
registry: ghcr.io
Expand Down Expand Up @@ -81,6 +81,7 @@ jobs:

- name: package cleanup
uses: dataaxiom/ghcr-cleanup-action@v1
continue-on-error: true # action doesn't fail when this step fails
if: ${{ github.actor != 'dependabot' }}
with:
owner: nuts-foundation
Expand All @@ -91,6 +92,7 @@ jobs:

- name: package cleanup dependabot
uses: dataaxiom/ghcr-cleanup-action@v1
continue-on-error: true # action doesn't fail when this step fails
if: ${{ github.actor == 'dependabot' }}
with:
owner: nuts-foundation
Expand Down
Loading