Derive signer of JWT-VP from the kid header, not the 'iss' field #2678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reinkrul
requested changes
Dec 12, 2023
gerardsn
commented
Dec 13, 2023
Comment on lines
+72
to
+74
| if kid == "" { | ||
| return nil, errors.New("no kid header in JWT") | ||
| } |
There was a problem hiding this comment.
verifier.resolveSigningKey tries to apply some magic in case the kid header is missing or only contains the fragment. Should this also be applied here?
There was a problem hiding this comment.
I'd say not if missing, but yes if it only contains the fragment?
reinkrul
approved these changes
Dec 13, 2023
Comment on lines
+72
to
+74
| if kid == "" { | ||
| return nil, errors.New("no kid header in JWT") | ||
| } |
There was a problem hiding this comment.
I'd say not if missing, but yes if it only contains the fragment?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2679