feedback

vcr/pe/presentation_submission.go

@@ -150,7 +150,7 @@ func (s PresentationSubmission) Validate(presentation vc.VerifiablePresentation,
 		return nil, fmt.Errorf("credential submission is invalid: %w", err)
 	}
 	if len(expectedCredentials) == 0 {
-		return nil, errors.New("credential submission is invalid, credentials does not match the presentation definition")
+		return nil, errors.New("credential submission is invalid, credentials do not match the presentation definition")
 	}
 	// Marshal, then unmarshal descriptor mappings into interface{}, to make sure ordering and zero-handling is the same for both.
 	// Then, they can simply be compared to check that the submission

vcr/pe/presentation_submission_test.go

@@ -150,18 +150,10 @@ func TestPresentationSubmission_Validate(t *testing.T) {
 				},
 			},
 		}
-		submission := PresentationSubmission{
-			DescriptorMap: []InputDescriptorMappingObject{
-				{
-					Id:   "1",
-					Path: "$.verifiableCredential[0].id",
-				},
-			},
-		}
 
-		credentials, err := submission.Validate(vp, definition)
+		credentials, err := PresentationSubmission{}.Validate(vp, definition)
 
-		assert.EqualError(t, err, "credential submission is invalid, credentials does not match the presentation definition")
+		assert.EqualError(t, err, "credential submission is invalid, credentials do not match the presentation definition")
 		assert.Empty(t, credentials)
 	})
 	t.Run("credentials match wrong input descriptors", func(t *testing.T) {