Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt to new (v2) VFIO migration interface #654

Open
jlevon opened this issue Mar 10, 2022 · 8 comments
Open

adapt to new (v2) VFIO migration interface #654

jlevon opened this issue Mar 10, 2022 · 8 comments
Assignees

Comments

@jlevon
Copy link
Collaborator

jlevon commented Mar 10, 2022

Alex Williamson says:

+The only device-specific region type and subtype supported by vfio-user is
+VFIO_REGION_TYPE_MIGRATION (3) and VFIO_REGION_SUBTYPE_MIGRATION (1).

These should be considered deprecated from the kernel interface. I
hope there are plans for vfio-user to adopt the new interface that's
currently available in linux-next and intended for v5.18.

Which is this:

commit b042b27868c00142da1a7e31f4740a5fbd5628ed
Merge: cfb92440ee71 88faa5e8ead6
Author: Alex Williamson <[email protected]>
Date:   Thu Mar 3 09:51:03 2022 -0700

    Merge tag 'mlx5-vfio-v10' of https://git.kernel.org/pub/scm/linux/kernel/git/mellanox/linux into v5.18/vfio/next/mlx5-migration-v10

    Add mlx5 live migration driver and v2 migration protocol

Need to investigate and possibly adopt these changes.

@tmakatos
Copy link
Member

tmakatos commented Mar 10, 2022

@changpe1
Copy link
Contributor

Looks like the mmaped migration region isn't supported with the new interface.

@tmakatos
Copy link
Member

tmakatos commented Apr 1, 2022

I've started adopting the new API here: https://github.com/tmakatos/muser/tree/migration-v2

Next, I'll start implementing Python tests.

@tmakatos tmakatos changed the title adapt to new vfio migration interface adapt to new (v2) VFIO migration interface Apr 5, 2022
@likebreath
Copy link

@tmakatos @jlevon I wonder do you have an estimated timeline for adding the v2 migration support to upstream libvfio-user?

@jlevon
Copy link
Collaborator Author

jlevon commented Sep 15, 2022

@likebreath sorry, we don't right now, but we'd be very happy if somebody wanted to make some proposals :)

@likebreath
Copy link

@jlevon Thank you for the quick response. I would love to help and contribute.

I know @tmakatos had a WIP branch for this work: https://github.com/tmakatos/muser/tree/migration-v2. Is this the right place to pick-up the work? Also, can you please provide me a summary about what are the missing bits? Thank you.

@tmakatos
Copy link
Member

I know @tmakatos had a WIP branch for this work: https://github.com/tmakatos/muser/tree/migration-v2. Is this the right place to pick-up the work?

Yes, this is the right branch, specifically this commit: tmakatos@059aa82

Also, can you please provide me a summary about what are the missing bits?

Unfortunately it's been so long that I forgot the details, I would have to start from the beginning (re-read the kernel API, re-read my patch etc.). Could you try to see whether the commit makes sense and if not I can see how I could help?

@likebreath
Copy link

Yes, this is the right branch, specifically this commit: tmakatos@059aa82

Could you try to see whether the commit makes sense and if not I can see how I could help?

Sure. I will let you know when I need your inputs. I will also keep you posted when I have a timeline for this work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants