Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't call prepare_data if get_pending_bytes returned 0 in pre-copy state #652

Closed
tmakatos opened this issue Feb 25, 2022 · 1 comment
Closed

don't call prepare_data if get_pending_bytes returned 0 in pre-copy state #652

tmakatos opened this issue Feb 25, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@tmakatos
Copy link
Member

If the device is in pre-copy state and the get_pending_bytes callback returned zero, the client shouldn't attempt to read the data_offset register, but if they do then we shouldn't call the device's prepare_data callback. This way we make the API simpler and easier to use for the device.
@tmakatos tmakatos added the enhancement New feature or request label Feb 25, 2022
@tmakatos
Copy link
Member Author

tmakatos commented Apr 5, 2022

obsolete by #654

@tmakatos tmakatos closed this as completed Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tmakatos