Skip to content

Commit

Permalink
Removes setting BAZEL_BUILD_EXTRA_OPTIONS in .devcontainer/setup.sh (
Browse files Browse the repository at this point in the history
…envoyproxy#37354)

This removes the unnecessary default bazelrc configuration used in
.devcontainer.
This was a cause of envoyproxy#23239 people asked about multiple times before.


Closes envoyproxy#23239


Signed-off-by: Takeshi Yoneda <[email protected]>
  • Loading branch information
mathetake authored Nov 25, 2024
1 parent e4cbfee commit e317854
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions .devcontainer/setup.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,6 @@

BAZELRC_FILE=~/.bazelrc bazel/setup_clang.sh /opt/llvm

# TODO(phlax): use user.bazelrc
# Use generated toolchain config because we know the base container is the one we're using in RBE.
# Not using libc++ here because clangd will raise some tidy issue in libc++ header as of version 9.
echo "build --config=rbe-toolchain-clang-libc++" >> ~/.bazelrc
echo "build ${BAZEL_BUILD_EXTRA_OPTIONS}" | tee -a ~/.bazelrc

# Ideally we want this line so bazel doesn't pollute things outside of the devcontainer, but some of
# API tooling (proto_sync) depends on symlink like bazel-bin.
# TODO(lizan): Fix API tooling and enable this again
Expand Down

0 comments on commit e317854

Please sign in to comment.