fix: Parse flags before loading kubeconfig #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlipovetsky
commented
Jan 15, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #494 +/- ##
==========================================
- Coverage 33.46% 33.45% -0.02%
==========================================
Files 17 17
Lines 2235 2236 +1
==========================================
Hits 748 748
- Misses 1467 1468 +1
Partials 20 20 ☔ View full report in Codecov by Sentry. |
thunderboltsid
approved these changes
Jan 16, 2025
|
tests seem to be failing due to CVEs: fixed in #495 |
To respect the --kubeconfig flag, we must parse it before loading the kubeconfig.
thunderboltsid
force-pushed
the
jira/NCN-105235
branch
from
4216b8a to
296a534
Compare
yanhua121
reviewed
Jan 16, 2025
yanhua121
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
To respect the --kubeconfig flag, we must parse it before loading the kubeconfig.
This fixes a bug introduced by #383, where we begin parsing flags after loading the kubeconfig.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
How Has This Been Tested?:
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration and test output
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: