Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: performance issue of comment doc queries #171

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Conversation

blindFS
Copy link
Contributor

@blindFS blindFS commented Dec 17, 2024

Fixes #170
Basically caused by inefficient highlight queries.

@fdncred
Copy link
Collaborator

fdncred commented Dec 17, 2024

cool. thanks. i'm surprised that could cause the cpu to spin up like it did.

@fdncred fdncred merged commit e36dde8 into nushell:main Dec 17, 2024
3 checks passed
fdncred pushed a commit that referenced this pull request Dec 18, 2024
The doc comment string of a parameter is actually parsed as a child node

Forgot to check it in #171 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

100% CPU usage in new example configuration
2 participants