-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support external event queue #822
Draft
mrdgo
wants to merge
19
commits into
nushell:main
Choose a base branch
from
mrdgo:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
4117bb6
feat: support external event queue
4c05b68
fix: remove unnecessary queue for raw events and rename queue for act…
651120a
fix: `unwrap()`-less implementation
b450164
fix: remove debug print statement
3889931
feat: support external event queue
f30ddc7
fix: remove unnecessary queue for raw events and rename queue for act…
a33029e
fix: `unwrap()`-less implementation
d09670d
fix: remove debug print statement
9d9060b
refactor!: Arc<Mutex<>> to mpsc::channel
43ab35b
Merge branch 'main' of github.com:mrdgo/reedline
e211ff6
chore: cleanup leftovers from merge
ecf33d4
fix: drain channel before handling all events
95a84f7
feat!: immediately accept bashisms
b67e45f
fix: apparently reedline doesn't log. So I don't, either
94817bb
fix: naming convention on unused variables
8f6b412
fix: typo, again
4b62bc4
Merge branch 'main' of github.com:nushell/reedline
8090786
feat: make immediate execution of bashisms configurable
8aff403
undo: most of configurable immediately execution of bashisms
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be good to remove these comments too