Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also run clippy on examples #666

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Conversation

Hofer-Julian
Copy link
Contributor

This PR also fixes existing clippy lints

This PR also fixes existing clippy lints
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Merging #666 (4a98ac6) into main (d9e0a32) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #666   +/-   ##
=======================================
  Coverage   49.15%   49.15%           
=======================================
  Files          43       43           
  Lines        7924     7924           
=======================================
  Hits         3895     3895           
  Misses       4029     4029           

Copy link
Member

@sholderbach sholderbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for trying to improve our tooling here, and fixing the examples.

The wording around the build target flags is a bit unclear so no foul.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@sholderbach sholderbach merged commit 63c43a9 into nushell:main Nov 14, 2023
8 checks passed
@Hofer-Julian Hofer-Julian deleted the clippy-examples branch November 14, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants