Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: migrate and extend history search #60

Closed
wants to merge 6 commits into from
Closed

feat: migrate and extend history search #60

wants to merge 6 commits into from

Commits on Jun 18, 2021

  1. feat: implement an interactive_history_search 

    * This PR addresses this Issue nushell#55
* BasicSearch was removed
* Additional features are an interactively displayed list, 
  that is scrollable with CTRL-n/CTRL-r or CTRL-p
* Maybe in the future make the displayed list optional?
* The interactive_history_search has its own loop, handling 
  input events, to make more complicated behavior easier maintainable 
  and removing history_search_state from the main loop in `read_line_helper`
    ahkrr committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    f9a60bf View commit details
    Browse the repository at this point in the history

  2. reduce code duplication

    ahkrr committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    aa0c077 View commit details
    Browse the repository at this point in the history

  3. fix: adding terminal_size adjustment back

    ahkrr committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    4cccdec View commit details
    Browse the repository at this point in the history

  4. reduce number of function_calls 

    by reusing local variable
    ahkrr committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    da5152c View commit details
    Browse the repository at this point in the history

  5. added TODO

    ahkrr committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    45d63e1 View commit details
    Browse the repository at this point in the history

  6. adjust terminal_size after interactive_history_search

    ahkrr committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    74cd304 View commit details
    Browse the repository at this point in the history